smooth_seams does not work when generate_brim is used. about compas_slicer HOT 3 CLOSED

Hello! I don't think there should be a different behavior depending on the previous slicer functions that have been done - this would lead into complicated interdependencies. In this case in particular, in my understanding, the smooth_seams should completely ignore the brim layer because it contains several paths. Also, I am testing it on the example 1, and I don't see the problem.

from compas_slicer.

Indeed completely ignoring the first layer could be a solution that also works for the brim. I'll see what I can do. Also the reason that in example 1 there is no problem is because it does not actually execute the seams_smooth script because of the following code:

if len(layer.paths) == 1:
    execute script
else:
    logger.warning("Smooth seams only works for layers consisting out of a single path, paths were not changed, seam smoothing skipped")
    break

from compas_slicer.

Yes , that's exactly what I mean. Sorry if it wasn't clear, I didn't mean it should completely ignore the first layer! But since it already ignores layers that have more than one paths (such as the brim layer), then I don't see how there is a conflict between the two functions (brim and seams_smooth)

from compas_slicer.