Code Monkey home page Code Monkey logo

Comments (4)

joburger avatar joburger commented on June 12, 2024

I think I see what you mean but I'm not sure what this would change? This would only have an effect on the first path of a layer right? Because currently the seams_align method never changes the first path (path0), instead it aligns the seam of path1 such that it is closest to the seam of path0, then it aligns the seam of path2 such that it is closest to the seam of path1, and so forth.

See image:

image

If this would also take into account the previous path, it would change also the first path (path0) to be closest to path1 (see poorly drawn image). But then it would not change anything in the further seam changing, right? Still, it could be good to also consider the first path but it does not change so much right? Perhaps we should discuss in person so that it's clearer.

image

from compas_slicer.

joburger avatar joburger commented on June 12, 2024

Closed it for now

from compas_slicer.

ioannaMitropoulou avatar ioannaMitropoulou commented on June 12, 2024

The way it is made right now, it doesn't fix the start point of the first path. See the example in the image below (coming from example_1).
Capture

from compas_slicer.

joburger avatar joburger commented on June 12, 2024

Yes you are right! I'll fix this asap.

from compas_slicer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.