Comments (4)
I think I see what you mean but I'm not sure what this would change? This would only have an effect on the first path of a layer right? Because currently the seams_align method never changes the first path (path0
), instead it aligns the seam of path1
such that it is closest to the seam of path0
, then it aligns the seam of path2
such that it is closest to the seam of path1
, and so forth.
See image:
If this would also take into account the previous path, it would change also the first path (path0
) to be closest to path1
(see poorly drawn image). But then it would not change anything in the further seam changing, right? Still, it could be good to also consider the first path but it does not change so much right? Perhaps we should discuss in person so that it's clearer.
from compas_slicer.
Closed it for now
from compas_slicer.
The way it is made right now, it doesn't fix the start point of the first path. See the example in the image below (coming from example_1).
from compas_slicer.
Yes you are right! I'll fix this asap.
from compas_slicer.
Related Issues (20)
- COMPAS SLICER stylizing
- Add attribute minimum/maximum z height to Layers
- When sorting into vertical layers, a safety_printpoint is always added even if it's not always necessary HOT 2
- Generate brim and sort into vertical layers
- error during preprocessing [curved slicing] HOT 4
- Path types differentiation
- Prepare function that generates infill
- Update gh visualization component of the slicer
- Improve path simplification HOT 1
- Update PrintPoints: content, export/import, iterators
- Update PrintPoints gh visualization component
- Investigate libigl slicing function for planar/scalar field slicing
- Cgal slicing, differentiate open vs closed contours HOT 1
- Bug in unify_paths_orientation: points are deleted and paths not always unified well
- matplotlib dependencies prevents from use in Rhino HOT 2
- Describe the workflow of compas slicer better
- Exception when running script ex2_curved_slicing_advanced.py HOT 4
- Add installation of igl to installation steps
- Issued in advanced curve slicing
- Comment Exposed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compas_slicer.