Code Monkey home page Code Monkey logo

Comments (2)

thhermansen avatar thhermansen commented on July 23, 2024

I have been working on this. Seems to be easy to do, thanks to ActiveModel. By default we are protecting id and inheritance attribute for single table inheritance models from being mass assigned. Meaning that for instance doing this: person.update_attributes(:id => 'new_id') will filter away id. That is a good thing so we don't allow people to manipulating ids.

Another situation which is affected by this is when doing Person.new(:id => 'an_id'). This will no longer work; instead, we must now do person = Person.new; person.id = 'an_id' (or just use default_id). I thought about allowing mass assignment of id when doing Person.new, and disallow it on person.attributes = a_has_of_attributes, but I found it to be way too risky and the chances of someone doing Person.new(params[:person]) without thinking about it's implications was too big.

So, I would say chances are good for this feature to break old code, but we need to have this in place :-)

from massive_record.

thhermansen avatar thhermansen commented on July 23, 2024

Implemented in develop: 88eadbc

from massive_record.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.