RFC: default system image building behaviour about comonicon.jl HOT 7 CLOSED

on the other hand, I think eventually we are going to make IonCLI a self-contained executable, which means it will ship with a small libjulia so I think all these issues won't happen for IonCLI side in the future, but I still need to wait for the progress of PackageCompiler.

from comonicon.jl.

let users to build it manually via a generated function XX.comonicon_build()

Here's my reasoning: If building the sysimage is just an optional optimization step, and if users could use XX without building the symimage, it is okay to not build them by default. But if not, since he/she has to build the sysimage manually to use the functionality, not running a fallback solution seems not that friendly.

from comonicon.jl.

Whether we should build sysimage as a fallback solution is not the key problem here. It is just a way to make sure things functioning; it could be slow to build but it is reliable.

Take the example of IonCLI, we should either provide a way to use IonCLI without sysimage, or provide better sysimage support/coverage.

from comonicon.jl.

for a complicated CLI application like IonCLI, it will take a lot of time to start, I think fallback to local system build should be a better workaround.

provide better sysimage support/coverage.

The main issue is PackageCompiler cannot generate the correct system image on GitHub action, and I'm not sure about why. Yeah, I agree if we treat the downloaded system image as an optimization, then building locally is something acceptable. I'll bring back the old behaviour on this.

from comonicon.jl.

It seems that this still doesn't work:

┌ Error: Error building `IonCLI`:
│ ERROR: LoadError: ArgumentError: Package Test not found in current path:
│ - Run `import Pkg; Pkg.add("Test")` to install the Test package.
│
│ Stacktrace:
│  [1] require(::Module, ::Symbol) at ./loading.jl:893
│  [2] include(::Function, ::Module, ::String) at ./Base.jl:380
│  [3] include(::Module, ::String) at ./Base.jl:368
│  [4] exec_options(::Base.JLOptions) at ./client.jl:296
│  [5] _start() at ./client.jl:506
│ in expression starting at /Users/jc/.julia/packages/IonCLI/04Jl6/test/runtests.jl:3
│ ┌ Error: Download failed: curl: (22) The requested URL returned error: 404 Not Found
│ └ @ Base download.jl:43
│ ┌ Warning: fail to download https://github.com/Roger-luo/IonCLI.jl/releases/download/v0.5.0/ion-1.5.1-darwin-x86_64.tar.gz, building the system image locally
│ └ @ Comonicon.BuildTools ~/.julia/packages/Comonicon/aSFTN/src/tools/build.jl:295

from comonicon.jl.

Yeah, this is because when building system image, we will execute tests to generate precompile statements. I just updated IonCLI, can you check if this works for you now?

from comonicon.jl.

Great! It works now. 🎉

from comonicon.jl.