Code Monkey home page Code Monkey logo

Comments (11)

michael-hawker avatar michael-hawker commented on August 10, 2024 2

Thanks for that info @mrlacey, FYI #9 shows the prototype we had with dotnet new template (which seems to work pretty well) and some initial testing infrastructure setup examples (though based off before we finalized our current structure for the sample app itself and how it works).

from labs-windows.

shweaver-MSFT avatar shweaver-MSFT commented on August 10, 2024 1

part of that is in main already #11

@michael-hawker, what part do you mean? Not the template... do you mean the extra uno requirements? I'm not expecting any conflicts, because all of my work is in the Template folder so far.

I see some good structure from #11 in the CanvasLayout sample. But I'm hesitant to adopt any uno patterns until we've figured out the mechanism to support the uber sample, which #12 seems to be focused on.

I can focus on getting the UI tests working from CI, while you guys handle the uber sample mechanism. Sound good?

from labs-windows.

mrlacey avatar mrlacey commented on August 10, 2024 1

A new PR for this is now at #76 as the solution structure and requirements have evolved since #9 was worked on.

The biggest changes in the requirements for this are:

  • No need to directly integrate the generated experiments with other (All) solutions.
  • The inclusion of UI tests has been deferred (until we have confidence in a good multi-targeted solution)

from labs-windows.

Arlodotexe avatar Arlodotexe commented on August 10, 2024

The template infrastructure will need to be able to add a reference to the new sample in the uber-sample uwp/wasm heads automatically when the project is created.

from labs-windows.

shweaver-MSFT avatar shweaver-MSFT commented on August 10, 2024

@michael-hawker @Arlodotexe what do you think about merging in the template before we apply the uno changes? I think this might be a nice checkpoint to settle on the basic template contents and then layer then uno requirements on top.

It's in a good working state, so I'm hoping the tests and template generation to continue to work after we apply the uno upgrade.

from labs-windows.

michael-hawker avatar michael-hawker commented on August 10, 2024

@shweaver-MSFT part of that is in main already #11, can you see what conflicts you see if you rebase? The other PR #12 Arlo has open is about sample loading for us to handle multiple samples which is relatively isolated still.

from labs-windows.

michael-hawker avatar michael-hawker commented on August 10, 2024

Yeah, sounds good @shweaver-MSFT! I'll take a look at the template PR in more depth and give it a spin locally. Will let you know if I run into any issues. Thanks!

from labs-windows.

shweaver-MSFT avatar shweaver-MSFT commented on August 10, 2024

I went through the exercise of porting the UITest projects over from the main toolkit, and I'm not convinced it's the right thing to do. Just because it adds so much extra to the template. We go from one UI test project to four just for the sake of working in the CI. I fear it'll create a ton of duplicated boilerplate test code across the repo, and it's not as dev friendly.

Perhaps we can work it into the uber sample somehow...

from labs-windows.

Arlodotexe avatar Arlodotexe commented on August 10, 2024

Considerations

Random bits discovered while fleshing out the sample system that should be taken into consideration for the template system.
Will be updated over time, until we're ready to complete the template infrastructure.

Project template.

  • When a new sample project is created, it should be added to
    • Codespace launch config file. See here
    • Multi-sample solution
    • Each deployable multi-sample project head

Sample page template

  • Initial sample ID should be unique, scoped to class/namespace. See here

from labs-windows.

mrlacey avatar mrlacey commented on August 10, 2024

VSIX was a suggested alternative, but it doesn't support more than one project at a time. We need to be able to generate multiple projects at once.

Not true ;)
But I get I'm late to this discussion and a VSIX has other limitations that might not be appropriate

from labs-windows.

mrlacey avatar mrlacey commented on August 10, 2024

closed by #76

from labs-windows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.