GitHub checks can be bypassed by an admin about easycla HOT 6 CLOSED

Hi Mike. Just to reiterate to make sure I understand. Do we want to limit admin's ability to merge code in the scenario that the user does not have a signed CLA? We'll have to look at what GitHub permits from Apps installed on Repos. I don't think it's generally permitted to restrict Admin activities, but we'll research this.

from easycla.

I'll be working with CNCF to see how v1 enforces this.

from easycla.

@kriva03 @pranab-bajpal based on my understanding, this is a GitHub restriction/policy/feature. Owners of a given repository can force merge a PR using their Admin permissions. This is outside the scope of EasyCLA. Please confirm.

from easycla.

Yes @dealako it seems like this depends on how the repo is setup. I found this in github help pages
https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. If you follow these steps you can force status checks on Administrator too. I don't think this in EasyCLAs domain.

from easycla.

The Google CLA bot actually allows project admins to bypass the check in a few conditions. It's basically designed to act as a break-glass feature in cases where the bot is wrong or down or something else goes wrong.

Maintainers can manually check that an individual signed the CLA, and then leave this information as a comment on the PR before bypassing.

from easycla.

After discussing, we are closing this issue as this is a GitHub feature/limitation (not an EasyCLA configuration setting).

from easycla.