Code Monkey home page Code Monkey logo

Comments (5)

ChristianMayer avatar ChristianMayer commented on September 22, 2024

@peuter right now my analysis of the issue is in a dead end. Could this be a timing issue where the changePageSizeInvalid is sent before the reading of the available space with window.getComputedStyle() is giving the correct number?

from cometvisu.

peuter avatar peuter commented on September 22, 2024

Seems like a timing issue, if I just defer the __invalidateScreensize call (in Slide.js constructur) it works for me:

this.__pageSizeListener = cv.ui.layout.ResizeHandler.states.addListener('changePageSizeInvalid', () => {
   (new qx.util.DeferredCall(this.__invalidateScreensize, this)).schedule();
});

(only tested in chrome with device emulation).

Maybe we need another event that is sent when the page size is valid again and you have to listen to that one?

from cometvisu.

ChristianMayer avatar ChristianMayer commented on September 22, 2024

Documentation is very sparse about browser generated events during and after a page turn and validation.

In the meantime, and as I'm currently suspecting that only 0.12 is affected I created a hotfix that should suffice as a band aid.

from cometvisu.

peuter avatar peuter commented on September 22, 2024

In the meantime, and as I'm currently suspecting that only 0.12 is affected I created a hotfix that should suffice as a band aid.

That suspection is wrong, I can easily reproduce the same behaviour with the current development-branch. But my fix also works there, so I assume yours will too. So I suggest to cherry-pick it into the development branch. But there is one additional problem in the dev-branch: Inititialy the slider knob is way too far left (initial value is 100%), the fix does not change that.

from cometvisu.

ChristianMayer avatar ChristianMayer commented on September 22, 2024

This issue actually caused multiple troubles on my side as the android browser behaved differently than the desktop chrome - and remote debugging of the android browser stopped the input events from working there 😲

So it's more a hot fix than a clean fix that solves the underlying timing issue. But it should be easy to cherry pick until there's a real fix.

from cometvisu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.