Fails with large values in memcached about crystal-memcached HOT 5 CLOSED

@samfrench Thank you for raising the issue, I'm going to take a look.

from crystal-memcached.

@samfrench I think I fixed the problem. Could you please check if it works for you now? Thanks!

from crystal-memcached.

Thank you @comandeo. When I run the specs they pass. I am still getting an error with my application as only puts 8164 characters in the cache which is a truncated output. I am currently investigating why this is. If I can't solve it I'll try and get a failing test to replicate the scenario as it might be something I am doing incorrectly.

from crystal-memcached.

It actually looks like our large value we are putting into memcached has a non-utf8 character. This is now where the value is breaking for us, so this issue has been resolved as we can now put large values into memcached and retrieve them. Thank you for the quick fix @comandeo as this allows us to progress further with our application.

from crystal-memcached.

@samfrench Thanks for the feedback, I am closing this issue.
However, you gave me some food for thoughts. Values in memcached seems to be just bytes - https://github.com/memcached/memcached/wiki/BinaryProtocolRevamped#data-types Maybe it is a good idea to allow clients to operate with slices, but not strings as values. Something like

def get(key : String) : Slice(UInt8)?

from crystal-memcached.