Code Monkey home page Code Monkey logo

Comments (3)

carbonatedcoder avatar carbonatedcoder commented on September 22, 2024 1

@CharlesMangwa thanks for your reply! Perhaps it would be a good idea to specifically callout this additional step in the react-native-modalfy installation instructions? After looking into the issue a bit more, I've seen other libraries mention adding the GestureHandlerRootView as a required step.

The react-native-gesture-handler docs do mention: "If you're using gesture handler in your component library, you may want to wrap your library's code in the GestureHandlerRootView component. This will avoid extra configuration for the user."

Given that modalfy has opted for the user to add it themselves, and it is required for modalfy to work, it's probably helpful to mention in the installation steps.

from react-native-modalfy.

CharlesMangwa avatar CharlesMangwa commented on September 22, 2024 1

@carbonatedcoder sure thing! and indeed, libraries like reanimated do mention this step is needed from the user.

my mistake! i was certain we did mention it in our docs as well but that was not indeed not the case, the installation guide has been updated to reflect that now.

thanks again for the feedback and i hope modalfy is being of some assistance in whatever you're building!

from react-native-modalfy.

CharlesMangwa avatar CharlesMangwa commented on September 22, 2024

@carbonatedcoder hi! as you've mentioned in your update, you need to use GestureHandlerRootView. but as mentioned in the docs: that's being done either by a library or by yourself at your app entry point.

that's why modalfy has always opted for letting you add it yourself in case you didn't have a library that did it. since GestureHandlerRootView is simply View, you may have styles or methods you'd like to pass to it.

from react-native-modalfy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.