Comments (3)
@CharlesMangwa thanks for your reply! Perhaps it would be a good idea to specifically callout this additional step in the react-native-modalfy
installation instructions? After looking into the issue a bit more, I've seen other libraries mention adding the GestureHandlerRootView
as a required step.
The react-native-gesture-handler
docs do mention: "If you're using gesture handler in your component library, you may want to wrap your library's code in the GestureHandlerRootView component. This will avoid extra configuration for the user."
Given that modalfy has opted for the user to add it themselves, and it is required for modalfy to work, it's probably helpful to mention in the installation steps.
from react-native-modalfy.
@carbonatedcoder sure thing! and indeed, libraries like reanimated do mention this step is needed from the user.
my mistake! i was certain we did mention it in our docs as well but that was not indeed not the case, the installation guide has been updated to reflect that now.
thanks again for the feedback and i hope modalfy is being of some assistance in whatever you're building!
from react-native-modalfy.
@carbonatedcoder hi! as you've mentioned in your update, you need to use GestureHandlerRootView
. but as mentioned in the docs: that's being done either by a library or by yourself at your app entry point.
that's why modalfy has always opted for letting you add it yourself in case you didn't have a library that did it. since GestureHandlerRootView
is simply View
, you may have styles or methods you'd like to pass to it.
from react-native-modalfy.
Related Issues (20)
- Modal does not animate out HOT 1
- Easy way to get modal props HOT 3
- Is it possible to check which modals are currently open before opening a modal? HOT 1
- Modal is opened again after close the first one HOT 6
- Need finish callback if noOpenedItems in queueClosingAction functions is true
- Sending `onAnimatedValueUpdate` with no listeners registered. HOT 6
- [iOS] open modal when screen has options presentation: "modal" HOT 4
- [Android] Cannot read property 'addListener' of undefined HOT 3
- CloseModal causes an infinite loop when used as a dependency for useEffect HOT 2
- How to configure the option to close automatically (e.g. after 3000 ms) and not to close when clicking on the background? HOT 2
- RN 0.73: FlingGestureHandler must be used as a descendant of GestureHandlerRootView. Otherwise the gestures will not be recognized. HOT 2
- Is it possible to make `params` non-undefined? HOT 1
- Responsive Background HOT 1
- Is it possible to pass a parameter which is a callback function to the modal? HOT 1
- Cannot select text or move cursor of TextInput inside a modal when keyboard is visible HOT 1
- Closing the modal immediately after opening for the second time on Fabric HOT 1
- Changing ModalOption from modal component HOT 3
- Unable to open a new modal in closeAllModals callback unless you use a timeout hack HOT 3
- disable BackHandler for android HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-modalfy.