[SUGGESTION]: Pre-commit checks about collaction_app HOT 8 CLOSED

The pre commit check fails a commit if one check fails. But hooks, like a CICD pipeline, should never introduce code changes.

Instead when you make a commit, the pre commit hook should be triggered, it will run the checks (formatter, analyzer) and tell you what's wrong.

from collaction_app.

If it's possible to show the output of these commands that would be a nice, since it would be kind of required to fix what stopped the commit from going through.

I also think we should use pre-push hooks instead of pre-commit hooks, since formatting and analyzing the code could take a considerable amount of time (many seconds).
We really only need to ensure that the code is "OK" when it is being pushed. Individual commits don't have to be checked in my opinion and we don't want to discourage frequent commits.

from collaction_app.

Yes, I think there is no such thing as Git without Bourne (Again) Shell aka (ba)sh

from collaction_app.

May replace https://github.com/CollActionteam/collaction_app/blob/development/cl.sh

from collaction_app.

Does the --dry-run flag work now as it does not come up as a flag on running flutter format --help?
If the intention is to not fix the code and only send the exit code then we can use -o none flag as this does the intended thing.

from collaction_app.

Also, we can just run flutter format --set-exit-if-changed . if we need to automatically fix any style errors.

from collaction_app.

Okay so do we need to show the files that need to be formatted in the output or it should just return with the exit code?

from collaction_app.

(should work with both bash and cmd)

@rubenhorn I think Git for Windows installs Git bash by default so will there be a need to create cmd script?

from collaction_app.