Support Unicode response message about aiosmtplib HOT 4 CLOSED

Another possibility just come to my mind is that we can just print out the formatted bytecodes that are not fit in utf-8 chars, my temp solution just to get rid of the error is something like:

message = line[4:].strip(b" \t\r\n").decode("ascii", errors='backslashreplace')

Thanks for giving very nice library.

from aiosmtplib.

Thanks for submitting. Yeah, I'm not sure how best to handle this. IIRC originally we just did UTF-8 decoding, but then the SMTP protocol actually requires ASCII responses, so I changed it to that.

I agree though this is situation where we might as well be liberal with what we accept (as you pointed out, there is still the status code). However:

1. I don't like using chardet here as it would be nice to avoid requiring any additional libs (currently they are only required for tests).
2. Stripping non-utf8 chars seems not ideal either, as character encoding issues could leave you with an empty response when there is actually data.

smtplib seems to avoid decoding response test altogether, which is a neat solution, although it would be a bigger change. Maybe it'll look at that though.

from aiosmtplib.

Yeah, I was just looking at that too 😄
I think backslashreplace should allow debugging without errors in most cases. That seems the best to me right now.

Glad you're finding it useful!

from aiosmtplib.

Fixed in 581d718.

from aiosmtplib.