Code Monkey home page Code Monkey logo

Comments (5)

neilhuang007 avatar neilhuang007 commented on May 25, 2024

If you try with versions 2.X, it will work

from recaf.

Col-E avatar Col-E commented on May 25, 2024

The mappings provided do not throw the NPE you'be listed with the class file you've given in 4.X

I assume some other class is causing the problem to occur. What game version are you targeting?

from recaf.

neilhuang007 avatar neilhuang007 commented on May 25, 2024

the game is runned in java 8

from recaf.

neilhuang007 avatar neilhuang007 commented on May 25, 2024

and i am using the newest github dev branch, could it be the issue with that?
here is a small video of me applying it, am i doing it right?
also here is the class file with the mappings
stuff.zip

2024-05-09.22-33-04.mp4

mabye its my issue with the branch or its a generic issue?

from recaf.

Col-E avatar Col-E commented on May 25, 2024

I'm not sure why I don't see the same issue on dev4 with the files you've originally provided but I did notice the field names weren't being applied. I'll push up the fix for that in a bit and it may also solve this NPE problem as well.

The gist is the mapping applier assumes all formats have fields declare what type they are, but SRG does not. Making the applier aware of this instead of assuming they all support it should work.

from recaf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.