Code Monkey home page Code Monkey logo

Comments (4)

colinrtwhite avatar colinrtwhite commented on June 6, 2024

Nice! I didn't think they were planning to support Js/Wasm, but agreed if Compose Multiplatform uses it we should too.

from coil.

colinrtwhite avatar colinrtwhite commented on June 6, 2024

The only downside to this is we limit our memory cache max size to the size of signed int, which is ~2GB. This almost certainly isn't an issue for mobile apps, but it could be a limit for desktop. That said, it's likely still worth it to replace our custom implementation.

from coil.

colinrtwhite avatar colinrtwhite commented on June 6, 2024

On second thought this might not be the best idea since it locks us into a max ~2GB memory cache size as mentioned previously. This could be a real limitation for image-heavy desktop apps. androidx's LruCache also has built in synchronization and locking, which we don't need.

from coil.

colinrtwhite avatar colinrtwhite commented on June 6, 2024

It looks like androidx.collection.LruCache doesn't publish versions for JS and wasmJs either unfortunately.

Given these limitations I think it makes sense to keep Coil's custom LruCache. It's small (<100 lines) so it should be fairly easy to maintain.

from coil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.