Code Monkey home page Code Monkey logo

Comments (9)

cognitom avatar cognitom commented on August 29, 2024

@peacepostman thanks for letting me know!
I'm bit busy for client work until next week... I haven't check 3.5 yet ><

If somebody knows workaround, pls share your idea. And of course PR is always welcome. Thanks ;-)

from symbols-for-sketch.

pudgereyem avatar pudgereyem commented on August 29, 2024

Just letting you guys know that it doesn't work for me either.
Any workaround yet? :) Thanks.

from symbols-for-sketch.

peacepostman avatar peacepostman commented on August 29, 2024

Some news from bohemianCoding,

I will just paste the mail content here :

We’re now bundling SketchTool inside Sketch. You can always find the latest version inside the app bundle (in Sketch.app/Contents/Resources/sketchtool) and install it from there.

Hope it helps!

Hope it helps too :)

from symbols-for-sketch.

johnmartin avatar johnmartin commented on August 29, 2024

@peacepostman @pudgereyem OK, I've had this problem too. It appears to be related to something todo with the fact that since Sketch 3.5 gulp-iconfont is not generating the correct unicode characters and therefore the generated CSS isn't playing nicely. I can't tell where the fault is at... BUT I've come up with a workaround (that works for me at least, until someone can up with a proper fix):

Basically you convert your unicode glyphs into their hexadecimal format and then use those within your generated CSS. I've done this by updating my gulp task as follows:

In your gulpfile.js:

// Imagine the normal gulp task for generation of files before here
.on("glyphs", function(glyphs) {
  for (var i in glyphs) {
    glyphs[i].hex = glyphs[i].unicode.toString().charCodeAt(0).toString(16);
  }
  // ... now carry on normally

In your css template: instead of using content: "<%= glyph.uncode %>" you'll need to use content: "\<%= glyph.hex %>"

For reference here's an example gist of it working: https://gist.github.com/johnmartin/0110aca0d00287d6f157

from symbols-for-sketch.

peacepostman avatar peacepostman commented on August 29, 2024

Thanks @johnmartin , I will give it a try and keep you updated.

from symbols-for-sketch.

pudgereyem avatar pudgereyem commented on August 29, 2024

Hey @johnmartin, @peacepostman and @cognitom.

I didn't get it to work the way @johnmartin suggested.

However, I went to https://github.com/cognitom/gulp-sketch and found this issue; cognitom/gulp-sketch#22 on the same problem. See @jackkeller's answer; cognitom/gulp-sketch#22 (comment)

Apparently the sketchtool is now included inside the app according to sketchapp.com/tool/. So by installing it from the route that they suggested I got it to work. You can check the changelog for sketchtool by writing sketchtool notes and there you should see (if you scroll up) a note for version 3.5.

Worked for me!

from symbols-for-sketch.

thabti avatar thabti commented on August 29, 2024

Guys just remove sketchtool from /usr/local/bin and install it as shown here :http://www.sketchapp.com/tool/

Worked like a charm .

from symbols-for-sketch.

peacepostman avatar peacepostman commented on August 29, 2024

Yep ! I couldn't add my feedback too for timing reasons, but install local sketchTool solves everything :)

@cognitom Issue closed I think, maybe add a note on readme for further issues and change gulp-sketch install method.

from symbols-for-sketch.

cognitom avatar cognitom commented on August 29, 2024

Hi guys, at last I got the time to fix some issues around Sketch.app 3.5.

  • gulp-sketch: 0.1.0 -> 1.0.3
  • symbols-for-sketch: 1.2.0 -> 2.0.0

@johnmartin thanks for letting us know the fix on Unicode issue. Feel free to send PR :-)
https://github.com/cognitom/symbols-for-sketch/blob/v2.0.0/gulpfile.js#L66

from symbols-for-sketch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.