Code Monkey home page Code Monkey logo

Comments (5)

cogdog avatar cogdog commented on July 20, 2024

Wordpress adds absolute positioning for auto embeds, I've never tried nor seen anyone try with an embedded URL but can see the problem.

Try adding to your CSS:

iframe.wp-embedded-content { position: relative !important; }

This will override the absolute positioning that Wordpress adds with the url embed. I'm not sure if this will adversely affect other embeds (e.g. tweets and videos), it's only a guess right now. Please let me know.

I like the Gigs, that's a lot of nice customizing of the interface.

from ds106bank.

ehelminen avatar ehelminen commented on July 20, 2024

Thanks for giving me the syntax. I had actually tried that, even with the "!important" marker, and it didn't do anything. But now that I see yours, I realize I had the semi-colon in the wrong place.

Appreciate your feedback! And thanks for the kind words. I was going to send you a message when the site was complete so you could take a look... Spilled the beans by needing help before it was done. ;)

from ds106bank.

cogdog avatar cogdog commented on July 20, 2024

An unrelated question, but wanted to ask seeing all the design customizations you have done... The bootstrap parent theme this is based on won't be updated. I did a short test, but it is possible that to roll all the customizations of the DS106 Bank into a single theme. That way you could do your mods as a child theme, making updates easier to manage.

Just checking your thoughts on this.

from ds106bank.

ehelminen avatar ehelminen commented on July 20, 2024

Seems like it would make sense. I haven't thought too much about how updates will work yet, although it did cross my mind that they might be a pain. (think I'm still in denial about that). I've made edits to CSS and a lot of the PHP files as well, so I shudder to think of what might be lost in updates, especially as I don't even fully understand the current structure or the way that Bootstrap is used here. I'm more of a novice with this stuff than it may look like on the surface. I don't think I've ever even used a Child Theme, although I understand why they're important and started to implement one once.

So yes, I like your idea to roll all the customizations into a single theme and I'm wondering if there's anything I need to/can do to help you with that process, and what I might have to do once that's done. Open to talking more! Thanks.

from ds106bank.

cogdog avatar cogdog commented on July 20, 2024

Once you start down making modifications to a theme, you have closed the door on being able to update w/o manual picking and editing. The way a child theme works is anything in it, like styles, or a different single.php supersedes the parent theme. And so if the parent theme is updated, you can do that and not lose your changes.

With qwhat I have done, the Assignment Bank theme is a Child of WP Bootstrap. In theory you might be able to do children of child themes (grandchildren) but it sounds fraught with peril.

Since WP Bootstrap will never be updated, if I combine them into one, you could then make your own child theme, with copies of the files you have modified. It might be a tad messy to get converted, but going forward it would mean your custom work can benefit from any featured I change (or more likely fix).

Might be a while before I get around to this, though.

from ds106bank.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.