possible logic error in 60_mastermind about basic-computer-games HOT 10 CLOSED

sure, does that ^ look good?

from basic-computer-games.

as promised #613

from basic-computer-games.

This is great -- let's be sure it is in the readme.md for the project as well!

from basic-computer-games.

I'll write something up later today

from basic-computer-games.

how should I go about doing that @coding-horror, there seem to be multiple precedents:

• a note saying when and what was patched (as in 02_amazing)
  or
• revert the change to the source and add a note detailing what the issues is and how future implementers should fix it (as in 84_super_star_trek)

from basic-computer-games.

Mainly I think the note should be in the readme.md in the game folder under implementation notes heading.. that seems like the best place?

from basic-computer-games.

Right, but which would you prefer, documenting what was fixed, or saying what should be fixed

from basic-computer-games.

both, if you have time! 🙏

from basic-computer-games.

well i think that settles it, issue is fixed so no use keeping this issue open

from basic-computer-games.

well i think that settles it, issue is fixed so no use keeping this issue open

I am unconvinced. Here is a 2 color, 2 position game, which is the simplest game that isn't just black or white as a possibility.

Here, with this fix, the computer guessed that same guess twice.

NOW I GUESS.  THINK OF A COMBINATION.
HIT RETURN WHEN READY:?
MY GUESS IS: WB  BLACKS, WHITES ? 1,0
MY GUESS IS: BB  BLACKS, WHITES ? 0,0
MY GUESS IS: WB  BLACKS, WHITES ? 1,0
MY GUESS IS: WW  BLACKS, WHITES ? 2,0
I GOT IT IN  4  MOVES!

I don't see how you were witnessing it throwing up the "you gave inconsistent results" every time unless you had the reporting of black and white pegs backwards.

from basic-computer-games.