Comments (4)
jeffslofish
commented on June 19, 2024
I would like to help with this.
from nyc-restaurant-inspection-records.
jeffslofish
commented on June 19, 2024
I made an initial react version here: https://github.com/jeffslofish/NYC-restaurant-inspection-records/tree/react (make you use the react branch), for your consideration. It has basic functionality but could definitely be improved. The UI is slightly different right now, but I believe that can be fixed.
It is fetching data from the server but I couldn't get my api token to work, so I am not using that. It does query the server based on restaurant name and borough though.
from nyc-restaurant-inspection-records.
CodeWritingCow
commented on June 19, 2024
Hi @jeffslofish, thank you for offering to help! There's a git branch for this issue. Please see what we're working on at react-base. My colleague @OmenwolF has converted most of the homepage into React. We're working on other parts of the website. It'd be great if you can help!
A couple comments:
- Your version uses Hooks, while react-base uses class components. What are the advantages of using Hooks?
fetchMyAPIhas the same functionality as search-controller.js, which runs server-side. Since the Socrata URL query string must include an API token to work, I think we should continue handling that functionality on the server. The token is less likely to be exposed to public view there.
from nyc-restaurant-inspection-records.
jeffslofish
commented on June 19, 2024
Hooks allow you to use only functional components which are simpler than class components.
I created pull request #46 which uses the existing react-base branch and adds search results to it.
I welcome any comments and suggestions.
from nyc-restaurant-inspection-records.
Related Issues (20)
- Add 500 error page and route
- Add neighborhood names
- Add ability to search records by restaurant address
- Add search bar to navbar
- Redesign search form
- Add geolocation search option
- Add complaints page
- Make form for advanced search
- Show random background image on homepage
- Add contact form
- Highlight navbar link for current page
- Require users to include restaurant name in search form
- Require users to include borough in advanced search form
- Remove jQuery as dependency
- Upgrade Materialize to v1.0.0 from v0.100.2
- morgan middleware
- Serve static assets with CDN
- Improve server speed with Redis caching
- Empty Results Page HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nyc-restaurant-inspection-records.