500 error when logging in about codetriage HOT 13 CLOSED

Ill have a look in a bit. Thanks for the issue.

Richard Schneeman
http://heroku.com
@schneems

Sent from the road

On Tuesday, February 26, 2013 at 12:57 AM, Patrik Stenmark wrote:

Hi
I'm having some problems logging in to codetriage.com. When I click the sign in button I just get a standard Rails 500 error ("We're sorry, but something went wrong."). It doesn't matter if I'm logged in to GitHub or not.

—
Reply to this email directly or view it on GitHub (#100).

from codetriage.

Yeah I have gotten the same error. I remove access to my Github account, and tried again same issue...

from codetriage.

I've got Waza tomorrow, traveling to Poland after that I'll prioritize this as my number 1 issue, but it might be a bit till I can really dig in.

Richard Schneeman
http://heroku.com

@schneems (http://twitter.com/schneems)

On Wednesday, February 27, 2013 at 12:35 PM, leondewey wrote:

Yeah I have gotten the same error. I remove access to my Github account, and tried again same issue...

—
Reply to this email directly or view it on GitHub (#100 (comment)).

from codetriage.

I just tried today and had no problems, though i've got quite a few people reporting this issue. Do you have a public or a private email address on your accounts?

After you get the 500, does "triage" show up in your authorized "applications" list on github? Do you see the "accept/deny" page on Github?

If i can't reproduce, i need as much info as possible.

from codetriage.

Same error for me too. Private email. After the 500 error, in the applications' list i got:
Issue Triage Production access user emails (readonly)

I've seen the accept/deny form on GitHub. If you need any more testing or information i'm glad to help.

from codetriage.

Added a public e-mail, tried and it worked. Removed the public email, logged out, still worked. Revoked the codetriage app from github, tried again, still working.

from codetriage.

Same here. Added a public email and it worked like a charm.

from codetriage.

Same here added a public email address and it work!

Maybe the auth does not return a email address. Since I have never given Github a public email address so it comes over as nil?

https://github.com/codetriage/codetriage/blob/master/app/models/user.rb#L83

from codetriage.

I'm having this problem too and I was debugging locally on my laptop and I think it happens for the first time you sign up when your GitHub public email is empty.

I'm getting this message on development.log:
NoMethodError (undefined method token' for #<Class:0x007fbdad7c3360>): app/models/user.rb:87:infind_for_github_oauth'
app/controllers/users/omniauth_callbacks_controller.rb:4:in `github'

I'm right now testing a fix for this on my laptop...

from codetriage.

I think the issue is on line 84 in the self.token
https://github.com/codetriage/codetriage/blob/master/app/models/user.rb#L84

Fails when User.rb#L84 has
email = GitHubBub::Request.fetch("/user/emails", token: self.token).json_body.first if email.blank?

Works when User.rb#L84 has
email = GitHubBub::Request.fetch("/user/emails", token: token).json_body.first if email.blank?

In the second scenario it successfully get my github email even with Public Email empty.

from codetriage.

just merged and pushed 103, please try again

from codetriage.

Cool... I delete my account and recreated with an empty email (on my git account) and it is working just fine!

from codetriage.

thanks, closing this for now

from codetriage.