Code Monkey home page Code Monkey logo

Comments (8)

genericmilk avatar genericmilk commented on May 12, 2024 1

Of course! The first screenshot has the issue after the animation, This is Safari 12.1.1 (14607.2.6.1.1) and appears to share the same issue with iOS

Screenshot 2019-05-24 at 14 24 21

After removing the motionfilter from the element for the figure it seems to correct itself (See number 5)
Screenshot 2019-05-24 at 14 24 35

Thanks so much again :D

from bounty.

genericmilk avatar genericmilk commented on May 12, 2024 1

Sure, I'll see what I can do πŸ‘ Cheers!

from bounty.

tylerdcorwin avatar tylerdcorwin commented on May 12, 2024 1

Ah Gotcha
I'll try resetting the filter attribute after the animation completes,
Thanks for the quick reply @coderitual, and thanks again for the great script!

from bounty.

genericmilk avatar genericmilk commented on May 12, 2024

On closer inspection it seems to be an issue with the style filter: url("#motionFilter-x-xxxxxxxxx"); - Safari in general (macOS too) doesn't seem to dump this filter on callback and leaves it enabled resulting in semi transparent text

from bounty.

coderitual avatar coderitual commented on May 12, 2024

Hi, thanks for the feedback. Yea there is a lot of issues related to filters across different browsers. Could attach some screenshots with the issue?

from bounty.

coderitual avatar coderitual commented on May 12, 2024

Uh oh, you are right. I think I saw this before. The solution might be to remove filters after animation finishes. Are you ok to work on a PR fixing this?

from bounty.

tylerdcorwin avatar tylerdcorwin commented on May 12, 2024

Hey there,

Great script, thanks for sharing!!
I'm having the same issue with the Pale colors, but not entirely sure what you mean by

removing the motionfilter from the element for the figure

Could you please elaborate on how I can fix this, or where to look?

Thanks!

from bounty.

coderitual avatar coderitual commented on May 12, 2024

Hi @tylerdcorwin
During animation there are filters applied to all elements which are being moved around (motion blur). This is done by setting specific filter id on particular element

::style('filter', `url(#motionFilter-${id})`);

Value of the motion filter is set to 0 after digit reaches destination (we don’t need motion blur when there is no motion). The filter is still applied though which causes issue. We can remove it from digit entirely (by resetting filter attr) after animation ends.

from bounty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.