will not work on multi user systems about sail HOT 16 CLOSED

Its only like a 5s delay so not crazy but still.

from sail.

If we're indiscriminately chmoding home, isn't it possible we override some intentionally set permissions?

from sail.

We're chowning it which should be fine.

from sail.

Is that because chown doesn't propogate a mac mount? Confused

from sail.

Its extremely unlikely any of the mounts contain files owned by a different user.

an alternative approach we could take is to pass in the UID to the build container as a build arg so that the image itself has the right uid from the get go.

from sail.

In the rare case there is, there can be some minor corruption. E.g, what if they sshfs a server to some directory in home? I know i've done that before.. This could infinitely traverse my remote server and fuck me up good.

from sail.

Just read the manpage, it turns out it only chowns files already owned by the user. Not sure how this interacts with mounts though. I'll give it a test.

from sail.

That doesn't make any sense... If the file is already owned by the user what good does chowning it to the same user do?

from sail.

Files aren't owned by the user, they're owned by the UID.

from sail.

isn't the uid 1:1 associated with user

from sail.

Yes, but if you change the UID for a user, you need to chown every file such thats its owned by the new UID.

from sail.

So turns out, the osxfs driver does the right thing by default: https://stackoverflow.com/questions/43097341/docker-on-macosx-does-not-translate-file-ownership-correctly-in-volumes

from sail.

So multi user systems are supported on macOS without any changes. Just linux that will end up being an issue.

from sail.

might be useful: https://github.com/boxboat/fixuid
coder/code-server#640

from sail.

Using that fixuid library to get CI working, seems to work pretty well

from sail.

Going to close as it has been a while and I'm not sure if this is relevant anymore.

from sail.