Comments (14)
Hi. I would like to work on this bug, would someone please assign this to me?
from codecombat.
You can't be assigned an issue if you are not a collaborator of the repo.
from codecombat.
Hi everyone.
I tried to approach this issue and came up with a solution. Now I would like to know your opinion. I consulted some non-programmer friends that occasionally use things such as CodeCombat to learn programming. The feedback that I got from them was mostly confusion about the yellow colored lines and less about the actual executing
line. After getting this feedback I came up with the following approach:
The check marks next to the executed
lines clearly highlights that this code was already executed. Additionally to that I changed the color of the executing
line to green, added an animation (from Twitter Bootstraps progress-bar) and made the color span the whole line instead of just the code. This shows better the activity that is going on there and both colors as well as gutter images support each other in getting a meaning.
Please let me know what you think and I'll submit a pull request.
from codecombat.
Maybe we can just tell the player that the arrow means "now executing" when, say, he goes through the tutorial and whenever he hovers the arrow out of curiosity? @dkundel 's proposal sure is very visible, but spamming heavy highlights and ticks on everything is kind of over-stimulating.
I suppose it isn't always possible to make something intuitive to the very end, and educating the players a bit seems like an easy and effective way out.
from codecombat.
An optimal UX shouldn't actually require to explain too much so I disregarded that option although it would be a possibility.
I tried to reduce the highlight of the executed lines to a minimal and made the check marks adapt better to the background. I tried to kind of stick to the style that was started with marking the comments on the side. My current view looks like this:
from codecombat.
Hmm, one thing that comes to mind is that we often show current statement execution for several different statements within the same line, not for the same line all by itself. So the background highlight probably shouldn't be for the whole line there, but rather just the currently executing statement. I wonder if the green striped design will be as clear with less contrast if it isn't always connected to the gutter arrow?
I kind of like the checkmarks on the side (but I'm no designer). We could merge that in and start UX-testing it to see how it goes.
from codecombat.
I see. Keeping the changes and just going back to highlighting the executing statement it would look the following:
I think it would work but it's harder to see the actual slow moving animation. I could increase the color by setting a higher alpha value which hover would make statements written in light blue (i.e. comments) harder to read.
from codecombat.
Comments won't ever be currently executing, though, so that would be okay. Want to submit a pull request and we can start trying it out?
from codecombat.
I like the improved contrast at 0.35
opacity, but at least to my eye, I want it to go way up, to something like 0.65
:
Thoughts?
from codecombat.
Would work for me but I tried it on three different screens for some it's hard to see the this
. It depends on how intensive your colors are. In general I think we should give it a shot and see how users react on it.
from codecombat.
Ah, the curse of different colors on different screens. We could also try changing the this
color to something else? I can't see the problem on any of my three screens with my two eyes, but my eyes aren't the best at colors.
from codecombat.
How would a light red look like for the this
statement?
from codecombat.
I've got the brighter green and the light red in. I can't see the red at all compared to black 'cause I'm colorblind, but whatever, the contrast is there.
from codecombat.
Thanks! Looks good :)
from codecombat.
Related Issues (20)
- Sweep: fix comment whitespace issues in translate-utils.coffee HOT 3
- Sweep: fix comment whitespace issues in translate-utils.coffee HOT 7
- Javascript: String.match() no longer works. Including the Sample code given.
- How to start?
- Unable to send translated text. HOT 2
- Hi everyone ! i can't copy a new level from a existing level HOT 1
- Unhandled error: distance's argument target... but got null HOT 2
- Seek-and-Hide Collision failure when hero is Okar HOT 1
- Terkunci semua nya all organisasi pemilik HOT 1
- Delete data HOT 1
- Fix this 2
- I can't install using docker HOT 5
- Buttons with long labels
- Unhandled error: TypeError: Cannot read properties of undefined (reading 'attackDamage') HOT 1
- "The Wizard's Door" & "Deja Brew" - level bugs - Java
- Issues with display HOT 6
- about.static.pug
- Solar Skirmish "Unable to load level" HOT 1
- How can I code
- Code input field broken HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codecombat.