Comments (7)
I'm working on this issue.
from codecombat.
I need some help with this issue.
combat.Arrow already has setAction 'die' and act true in its update function, which sets its action to die. The die state is displayed if action.Acts component is added to the Arrow thang, but an unexpected shadow(?) appears under the dead arrow sprites.
Should I refactor that and move this setAction functionality into a chooseAction function?
from codecombat.
Hmm, it seems like we need to add some code to stop drawing the shadow for arrows and spears that are dead, which we could try out in CocoSprite by checking if the ThangType name is "Arrow" or "Spear". If that works, we can make the shadow diameter specific to particular animations rather than the whole ThangType.
It sounds like the action being set to "die" is working? Or do I misunderstand?
from codecombat.
You understood everything right. "die" is already working if you add action.Acts to the Arrow object.
(like on my level: http://codecombat.com/editor/level/kgymap)
from codecombat.
By Jove, you're right! So the only step left to do is to add action.Acts to existing levels' Arrows and Spears and to stop drawing the shadow Mark when they are dead and their ThangType name is 'Arrow' or 'Spear'. Do you want to try editing CocoSprite to turn that shadow off?
from codecombat.
I've modified the arrow slightly so that instead of needing to use diesOnHit
(which prevents them from bouncing), they just always die when they hit the ground (instead of hitting a target or an obstacle). I am adding Acts
to all the arrows and spears, and it'll be in there by default for new instances in the level editor.
So now we just need to be able to disable the shadow appropriately.
from codecombat.
I've made it.
The shadow disappears when the arrow hits the ground.
I'll make a pull request.
#687
from codecombat.
Related Issues (20)
- #QUICK! Problem with Codecombat Ladder Giant's Gate
- An error appears when content is translated into Japanese and sent. HOT 4
- Sometimes no background music and no enemies appear. HOT 1
- I would like to translate all dynamic content into Japanese at once using ChatGPT. HOT 2
- Portuguese (Brazil) - English content in enemy-mine level HOT 2
- Virtual ISO with CodeCombat
- Sweep: fix comment whitespace issues in translate-utils.coffee HOT 3
- Sweep: fix comment whitespace issues in translate-utils.coffee HOT 7
- Javascript: String.match() no longer works. Including the Sample code given.
- How to start?
- Unable to send translated text. HOT 2
- Hi everyone ! i can't copy a new level from a existing level HOT 1
- Unhandled error: distance's argument target... but got null HOT 2
- Seek-and-Hide Collision failure when hero is Okar HOT 1
- Terkunci semua nya all organisasi pemilik HOT 1
- Delete data HOT 1
- Fix this 2
- I can't install using docker HOT 5
- Buttons with long labels
- Unhandled error: TypeError: Cannot read properties of undefined (reading 'attackDamage') HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codecombat.