Refactor Server about codecombat HOT 2 CLOSED

@sderickson Since @smoratinos reorganized everything, do you still want to keep this open? I guess migrating to Koa would be cool, but we should probably do that soon if we're going to, or it's going to keep getting harder.

I would be uncomfortable switching to Restify, because we're going to want something that's going to be well-supported and around for a while.

from codecombat.

Yes, there's still some reorganization to do. I think we can forget about replacing Express with something else unless someone really wants to do that as a personal project. But there are still a couple major things that really bother me about the current server setup:

• There's no good way to see what the actual routes available are. This is because some of it's in Handler subclass logic, and the db.coffee file tries to do a bunch of magic with path inspection.
• The logic for routes and data need to be separated. That is, it's kind of set up right now as if everything that starts with /db/ is in the collection, but that may not be the case because of 'getByRelationship'.

Then the major steps to do are:

• Refactoring of Handler to put data-related logic into the Models (like formatEntity, or getEditableProperties).
• Create a routes file which defines all the urls and parameters, using the Router middleware in express.

Really, I'd need to spend some time poring over the express documentation and probably going over some examples of express server implementations to figure out a nicer, more logical structure, but this is what I'm thinking right now. The way it is now is still kind of wonky and unintuitive, I think.

from codecombat.