total_records silently raises and returns 1 about effective_datatables HOT 3 CLOSED

Hey @sheldond

Thanks for your interest in this gem. It is indeed pretty awesome. :)

I have implemented a tiny bit of MySQL compatibility, but 99% of this gem has been developed with postgresql as the backend.

We can't just use collection.count here, as sometimes a datatable may have an extremely advanced def collection query that will not chain .count properly.

This particular line....returns a Hash for me. Interesting it would return an Array on MySql.

Any chance you have an example app I could check out and reproduce this error? Or feel upto writing a PR for this that checks the return value?

Thanks :)

from effective_datatables.

Cool thanks for your reply!

I tested this on postgres and indeed it works as expected!

Since this code is in Rails, not effective_datatables, the behaviour is easy to see by running something like this in any Rails project:

User.connection.execute("SELECT COUNT(*) FROM (SELECT * FROM users) AS datatables_total_count")

Using exec_query will wrap the result in a ActiveRecord::Result, which should have a common interface regardless of the db adapter.

It could be rewritten as (maybe there's something cleaner, but this works):

User.connection.exec_query("SELECT COUNT(*) FROM (SELECT * FROM users) AS datatables_total_count").rows[0][0].to_i

If the gem does not have full support for mysql I don't think I can use it for my current project, but I will certainly keep it in mind for postgres projects! :D

from effective_datatables.

Right on,

I may have time in a few weeks to take a look at this from the mysql perspective better.

Really, all the internals of this gem work with ActiveRecord. There isn't very much at all custom SQL going on. So things -should- just work with mysql. I'm surprised this issues came up, and I know this is working with postgresql, mysql and sqlite projects.

Thanks for the snippet and keep watchin' this repo.

Cheers.

from effective_datatables.