Code Monkey home page Code Monkey logo

Comments (8)

mac2000 avatar mac2000 commented on May 28, 2024

Can you please also provide example word and its transliteration with this letter, so we can add it to tests so never ever again this issue will not appear again :)

from slugify.

thangngoc89 avatar thangngoc89 commented on May 28, 2024

It's is my name :)
Nguyễn Đăng Khoa
The slug should be nguyen-dang-khoa instead of nguyen-djang-khoa.
Đ character is populate in Vietnamese but it have some restriction.
Đ has to follow by vowels (a,u,e,i,o). But you should run these vowels through Slugify because in Vietnames, it can be in many forms: à á ẻ ị ỉ ,.......

from slugify.

mac2000 avatar mac2000 commented on May 28, 2024

creted pull requests, when it will be merged into code your name will be part of slugify :)

from slugify.

thangngoc89 avatar thangngoc89 commented on May 28, 2024

Yeah. Thanks you. That seem fine now. 👍

from slugify.

florianeckerstorfer avatar florianeckerstorfer commented on May 28, 2024

@mac2000 You commit would overwrite the current behaviour. I don't know of any (other) language that uses Đ. But is D the only valid transliteration? Or is there another valid transliteration for another language?

from slugify.

thangngoc89 avatar thangngoc89 commented on May 28, 2024

@mac2000 one problems here: Đ and Đ. They are 2 different ways to type that characte

from slugify.

mac2000 avatar mac2000 commented on May 28, 2024

Initial set of transliteration rules was copy pasted from Wikipedia and other sources, now language speaking people correcting wrong assumptions about what is correct way to transliterate symbols, so in my opinion there is nothing bad, and actually D seems to be more correct rather than Dj, and after all if there is other cases we can always create new issues and take decision what to do next

*feel free to cancel this PR if you are afraid of something

from slugify.

florianeckerstorfer avatar florianeckerstorfer commented on May 28, 2024

Thanks for the clarification.

from slugify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.