crlfmt strips comments about crlfmt HOT 3 CLOSED

Seems like an unconventional place to put a comment.

On Oct 11, 2016 12:23, "Andrei Matei" [email protected] wrote:

/Users/andrei/work/src/github.com/cockroachdb/cockroach/storage/engine/mvcc.go:476
-func http://github.com/cockroachdb/cockroach/storage/engine/mvcc.go:476-func MVCCPutProto(

• ctx context.Context,
• engine ReadWriter,
• ms *enginepb.MVCCStats, // can be nil is the key is unreplicated and doesn't affect stats
• key roachpb.Key,
• timestamp hlc.Timestamp,
• txn *roachpb.Transaction,
• msg proto.Message,
  -) error {
  +func MVCCPutProto(
• ctx context.Context,
• engine ReadWriter,
• ms *enginepb.MVCCStats,
• key roachpb.Key,
• timestamp hlc.Timestamp,
• txn *roachpb.Transaction,
• msg proto.Message,
  +) error {

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdsPHoIjXIHjKpD-pWEK870lFOHjWoWks5qy7gagaJpZM4KT1D9
.

from crlfmt.

The fix for #5 could apply to this as well: first check if the existing code is correctly formatted, and if so don't change it. The code can also be conservative and just don't reformat something which contains comments or other extraneous stuff.

from crlfmt.

Looks like a perfectly reasonable place for a comment to me. In fact, allowing for per-parameter inline comments seems like one of the advantages of the one-parameter-per-line style.

from crlfmt.