splinter should stop the process when the page status code returns 404 (not found) about splinter HOT 14 CLOSED

Based on this issue, I think that selenium webdriver does not support this functionality. I have an alternative for this problem, but I don't know if it is the best solution. Another solution is to use a proxy, like this one.
What do you think?

from splinter.

Yes, selenium/webdriver does not support this functionality, I like your proposal, and I think that splinter will be works with any http exceptions, like 500, 404, etc.

What do you think?

from splinter.

Yeah, with this solution splinter will be able to work with any http status code.

I'll finish my code and make a pull request. ;D

from splinter.

It'll be nice if we can check any status code returned, not only 404.

from splinter.

Hey!
Should splinter stop it's process completely when it gets a http error?
Because now I'm raising an exception, which makes the test break and doesn't even open the page, what do you think about it, is this enough?

from splinter.

Which info do you provide in the exception? Are you raising an unique exception for all errors or one exception per error?

from splinter.

Yes I'm using an unique exception; I created a HttpResponseError exception, but when I raise it I pass the reason phrase returned by httplib, so if you try to access a page and get an 404 status code, you'll have an exception with the text "404 - Not Found"
So?

from splinter.

IMHO, HttpResponseError should encapsulate two attributes: status_code and reason.

Here is an example:

try:
    browser = Browser("webdriver.firefox")
    browser.visit("http://google.com.br/not_found_at_google")
except HttpResponseError as e:
    print "I have failed :( Status code: %d. Reason: %s" %(e.status_code, e.reason)
    # will print "I have failed :( Status code: 404. Reason: Not found

from splinter.

I merged the pull request and Splinter has this feature now, but we need docs, so I'm keeping this issue opened.

from splinter.

I'm closing that issue, since docs are written. ;)

from splinter.

What about fix the problem with non-HTTP protocols? :P

from splinter.

Yeah, you're right!
But I thought that maybe this could be another issue... I really don't know... ;)
What you think?

from splinter.

As @FranciscoSouza and I talked, I have already opened another issue, so I'm closing that.

from splinter.

How can I test if my 404 page is working correctly?
Is there any way I can expect a 404 and test its contents?

If I catch the exception I end up with browser.html containing the previous 200 page.

from splinter.