Code Monkey home page Code Monkey logo

Comments (13)

dotgourav avatar dotgourav commented on June 2, 2024 1

I apologize for the delay but here is what I came up with based on the scikit's PR template. I welcome suggestions on its improvement.

PR Template:

Description

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]

from documentation.

Adrianzatreanu avatar Adrianzatreanu commented on June 2, 2024

From @gitmate-bot on June 23, 2016 4:6

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

from documentation.

Adrianzatreanu avatar Adrianzatreanu commented on June 2, 2024

From @AbdealiJK on June 23, 2016 4:7

You can find their other templates and this one at https://github.com/scikit-image/scikit-image/tree/master/.github

from documentation.

Adrianzatreanu avatar Adrianzatreanu commented on June 2, 2024

From @hypothesist on July 2, 2016 15:58

We could also add something about doctests. Also modify the first check point to something like "Run coala on the project before submitting" as that should pretty much cover any code standards issue. (We could also convince scikit-image devs to use coala.)

from documentation.

dotgourav avatar dotgourav commented on June 2, 2024

Do you have some content in mind for this?

from documentation.

sils avatar sils commented on June 2, 2024

We should probably have a link to coala.io/commit at least, explain people that they should do rebases and stuff like this. Also mention that people should get assigned to an issue when wanting to work on it.

Btw. @gouravchawla I sent you a community invitation so I can assign you - would you be interested in fixing this? Actually I think this can save us a hell lot of time.

from documentation.

dotgourav avatar dotgourav commented on June 2, 2024

Yes, I would love to work on it. @sils1297

from documentation.

adtac avatar adtac commented on June 2, 2024

@gouravchawla assigned you 👍

from documentation.

underyx avatar underyx commented on June 2, 2024

As far as I know, you can use comments in markdown, so instead of

[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]

we could have

<!-- Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images. -->

which doesn't need to be deleted/replaced by the reporter.

from documentation.

dotgourav avatar dotgourav commented on June 2, 2024

Ok, i'll turn that into comments. The checklist would still need to be removed though, isn't it?

from documentation.

Adrianzatreanu avatar Adrianzatreanu commented on June 2, 2024

is this still needed?

from documentation.

sils avatar sils commented on June 2, 2024

from documentation.

jayvdb avatar jayvdb commented on June 2, 2024

Moved to coala/meta#117

from documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.