Comments (5)
vvatelot
commented on May 31, 2024
Hello @JulienWilhelm, sorry did not receive a notification on your issue 😅
What do you have in mind for localstorage here ?
I already apply a cache on the badge coming from the BFF:
Cache-Control: max-age=604800, public
Vary: Origin,X-Ecoindex-Url,X-Ecoindex-Theme
X-Ecoindex-Theme: light
X-Ecoindex-Url: https://www.ecoindex.fr
Isn't it enough ? 🤔
from ecoindex_badge.
JulienWilhelm
commented on May 31, 2024
I missed it! Sorry.
Maybe you should specified in README that the result will not updated for 7 days.
from ecoindex_badge.
vvatelot
commented on May 31, 2024
Ok, so I reopen the issue 🙂
from ecoindex_badge.
jpkha
commented on May 31, 2024
Should we limit the cache to 24 hours like the Ecoindex extension?
from ecoindex_badge.
github-actions
commented on May 31, 2024
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
from ecoindex_badge.
Related Issues (10)
- Refactoring code between light and dark version HOT 2
- Petits retours HOT 6
- Donner une width et une height à l'image HOT 1
- Quand on clic sur le badge, on ne tombe pas sur le bon rapport HOT 9
- Obligation d'avoir un trailing slash HOT 1
- Minify JS HOT 2
- Indiquer de manière explicite que l'analyse est limitée à une page donnée HOT 1
- When the score of a page doesn't exist, calculate it when a user clicks on the badge HOT 6
- Critical issue performance: if ecoindex is down, slows down site using badge HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecoindex_badge.