SwaggerBake Schema and SwaggerBake Routes executes even when hotReload is false about cakephp-swagger-bake HOT 6 OPEN

#544

from cakephp-swagger-bake.

I believe the reason is, even if with hotReload set to off, a user may still run this code via the CLI. In fact, running via the CLI (e.g. bin/cake swagger bake) is the recommended way to deploy to production.

I see your PR has a condition for SAPI CLI, but I am highly worried about introducing this change. Why? I don't know, other than I have a hunch this will cause problems for other users.

from cakephp-swagger-bake.

This is a valid issue and I will explore it more. However, I find it unlikely I will accept the PR for the reasons previously stated. For your specific case (I recall from slack you have something like 160+ routes), I would advise simply replacing SwaggerController with your own. The logic in there is very light:

https://github.com/cnizzardini/cakephp-swagger-bake/blob/2.x/src/Controller/SwaggerController.php

You may extract out the logic from the injected service (https://github.com/cnizzardini/cakephp-swagger-bake/blob/2.x/src/Lib/Service/OpenApiControllerService.php) and place it directly in your controller or define your own service and it inject it per: https://book.cakephp.org/4/en/development/dependency-injection.html

Is this a reasonable workaround to the performance issues your application is experiencing?

If you are keen on getting that PR passed, I will post a potential solution I might be okay with accepting in the PR.

from cakephp-swagger-bake.

I'm also curious if you identified the actual source of the performance issue. Knowing the specific cause, that is, the actual line or lines of code causing the performance issues is necessary for a resolution.

from cakephp-swagger-bake.

Also have you tried this: #454

from cakephp-swagger-bake.