Code Monkey home page Code Monkey logo

Comments (6)

dmethvin-gov avatar dmethvin-gov commented on June 10, 2024 1

Reviewing the use cases for the current Spinner, it made sense to me why it wouldn't show over a Dialog. So I'm good with that. Thanks!

from design-system.

pwolfert avatar pwolfert commented on June 10, 2024

Hi @dmethvin-gov!

The spinner component that we have in the design system is meant to be flexible and simple enough to use in any context that the application needs—from inside buttons to being a placeholder for content. It would be outside the scope of its design to force it to display above everything else, and in fact we can't for the very reasons you've shown with your example (because browser-made dialogs render above everything else). This is an example of something we'd place in the realm of application responsibility.

But perhaps I'm not understanding the request. What is it you're trying to do exactly? This is not a pattern we've seen used so far in healthcare.gov or medicare.gov or any other apps that we've seen using the design system.

from design-system.

dmethvin-gov avatar dmethvin-gov commented on June 10, 2024

No, you understood correctly. I have a dialog and want a modal spinner to appear when something in the dialog causes it to need to appear. We don't want the user to interact with the dialog while it's in the middle of exchaning data with the server, for example.

I see your point about the spinner though, since the examples show it spinning on a button and in that case it should be contained by the element it's within. So our use case isn't a good match for it. We'll need to create a custom component for it.

from design-system.

brentschneider avatar brentschneider commented on June 10, 2024

Hi @dmethvin-gov 

Before responding, I want to confirm my read on the interaction presented

On submit, the spinner appears over everything on the page in order to disable any interactions on the page until the data status returned changes the state?

this could be the data submitted was a success, or it could be failed- try again.

What you are after is interaction guidance that does not disrupt the flow— is that correct?

from design-system.

dmethvin-gov avatar dmethvin-gov commented on June 10, 2024

@brentschneider Your description sounds accurate. The data submit/fetch are async and there is a central location in the app that manages whether the spinner needs to be shown or not. The user may take actions in the dialog that require remote data. In that case, the data in the dialog may need to be changed and we want to ensure the data user doesn't, for example, start editing a field that a few seconds later will be updated from the server.

from design-system.

brentschneider avatar brentschneider commented on June 10, 2024

Dave, I saw you closed this issue on GH.
Did you want to continue the convo over in the #cms-design-system-team slack?

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.