Comments (4)
Hi Artur, the changes are probably fine but it seems like a significant amount of new code in plotImpacts.py, would like to understand it a bit better first before having it in the master branch. Maybe it's best to push a revert commit now and have a fresh PR?
cheers,
Andrew
from combineharvester.
Dear Andrew,
in case there is a possibility to omit the revert I would like to elaborate a bit on it here. The default behavior of the script is actually not changed (therefore many added lines, I didn't want to touch already working code just like that). Most of the added lines are implementing an automatic page break: when the next impact in the list is by an order of magnitude smaller compared to the previous one a new page is started such that all impacts would be visible. This is not necessarily achievable in a pretty way by limiting the maximum number of nuisances per page.
Cheers, Olena
from combineharvester.
Hi Andrew,
Ok, it's fine with me to do a git revert
now and do a proper PR to allow a possibility to comment on the changes. So if you give your "go" on this, I'll create a git revert
commit.
Cheers,
Artur
from combineharvester.
Ok changes reverted, PR's will follow
from combineharvester.
Related Issues (20)
- ValidateDatacards.py Problem: Systematic type autoMCStats not supported HOT 4
- ValidateDatacards.py fails in compiling RooFormulas
- PostFitShapesFromWorkspace produces single-bin histograms in some cases HOT 1
- shapeN not supported HOT 1
- ValidateDatacards.py does cannot read csv inputs. HOT 1
- ValidateDatacards.py looks for TH1 not required by datacard. HOT 1
- Deprecate old docs?
- PostFitShapesFromWorkspace development HOT 1
- Move CombineHarvester into Combine
- Shape template tools HOT 1
- ValidateCards.py development
- `RestoreBinning` does not properly work for some binnings, e.g. DNN scores? HOT 1
- Investigate post-fit sampling for the cases with high statistics and large lnN uncertainties HOT 3
- Need to replace R.Double with ctypes HOT 1
- CreateAxisHist function HOT 3
- Unexpected behavior generating toys from model with 2 POI
- Double no longer an attribute of ROOT for root version 6.22 HOT 3
- Unexpect rounding in the plotImpacts
- Nicer default impact plot HOT 1
- el8/el9 Compatibility HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from combineharvester.