Accidental push to cms-analysis CH instead of to the forked version about combineharvester HOT 4 CLOSED

Hi Artur, the changes are probably fine but it seems like a significant amount of new code in plotImpacts.py, would like to understand it a bit better first before having it in the master branch. Maybe it's best to push a revert commit now and have a fresh PR?

cheers,
Andrew

from combineharvester.

Dear Andrew,
in case there is a possibility to omit the revert I would like to elaborate a bit on it here. The default behavior of the script is actually not changed (therefore many added lines, I didn't want to touch already working code just like that). Most of the added lines are implementing an automatic page break: when the next impact in the list is by an order of magnitude smaller compared to the previous one a new page is started such that all impacts would be visible. This is not necessarily achievable in a pretty way by limiting the maximum number of nuisances per page.
Cheers, Olena

from combineharvester.

Hi Andrew,

Ok, it's fine with me to do a git revert now and do a proper PR to allow a possibility to comment on the changes. So if you give your "go" on this, I'll create a git revert commit.

Cheers,

Artur

from combineharvester.

Ok changes reverted, PR's will follow

from combineharvester.