Code Monkey home page Code Monkey logo

Comments (3)

luckman212 avatar luckman212 commented on August 25, 2024 1

I created a PR: #53
Not sure if it is correct, please take a look

from pinboard-plus.

luckman212 avatar luckman212 commented on August 25, 2024 1

Thank you @clvrobj

Right now, when clicking on the suggested tag, a space is prepended to the tag, e.g. 'twitter' becomes ' twitter' so the automatic extra space is not needed at the end of the taglist.

But, I think it might be better if clicking on the tag instead added 'twitter ' (space at the end) since right now, if taglist is empty, clicking on a suggestion puts an unneeded space at the beginning of the field. I will try to look more closely at the code to see if I can make the adjustment.

from pinboard-plus.

clvrobj avatar clvrobj commented on August 25, 2024

Hi @luckman212 , thanks for raising and fixing this!
The extra space at the end of the tags list is added intentionally, for saving a space user need to typing. User can input the tag immediately after open the popup window without input the space after the tags list.
The problem is actually it should not add the extra space incrementally. IMO adding a .trim() function before adding the space might be the best solution. I'll also comment in your PR #53 about this.
Thanks.

from pinboard-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.