Comments (3)
I created a PR: #53
Not sure if it is correct, please take a look
from pinboard-plus.
Thank you @clvrobj
Right now, when clicking on the suggested tag, a space is prepended to the tag, e.g. 'twitter'
becomes ' twitter'
so the automatic extra space is not needed at the end of the taglist.
But, I think it might be better if clicking on the tag instead added 'twitter '
(space at the end) since right now, if taglist is empty, clicking on a suggestion puts an unneeded space at the beginning of the field. I will try to look more closely at the code to see if I can make the adjustment.
from pinboard-plus.
Hi @luckman212 , thanks for raising and fixing this!
The extra space at the end of the tags list is added intentionally, for saving a space user need to typing. User can input the tag immediately after open the popup window without input the space after the tags list.
The problem is actually it should not add the extra space incrementally. IMO adding a .trim()
function before adding the space might be the best solution. I'll also comment in your PR #53 about this.
Thanks.
from pinboard-plus.
Related Issues (20)
- Use canonical URL instead of actual URL HOT 1
- Activate from Right-Click on Link
- API errors aren't communicated to users HOT 5
- Request: Add Keyboard Shortcuts for Extensions and Apps HOT 2
- "Please check your connection" warning message HOT 3
- Tab auto-complete only works on second load HOT 3
- Case sensitive auto completion for tags HOT 3
- Tab sets HOT 3
- Tag Suggestions Always the Same HOT 6
- Getting message "The post Sentry is not saved. Error" when creating a bookmark HOT 2
- Tag auto-completion/selection during input - 2 small bugs HOT 3
- Auto tagging from selected text
- Stopped working. timeout when trying to log in. HOT 4
- DevTools failed to load SourceMap HOT 4
- Do not truncate quotes from selected text HOT 1
- Make Dark Mode Icon Color Configurable HOT 1
- Red bar with message that the last pin entered is not saved - timeout error
- Internal server error HOT 1
- How to donate?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pinboard-plus.