cloudshark / wireshark-plugin Goto Github PK

the main website says 'download 1.0.4 from github' but there are no tags in the repo. Please tag versions so people know they are getting a "stable" release and not just current master

With Wireshark 2.0, specifically version 2.0.0rc2 when uploading a capture file the following error message sometimes appears:

Please create or load a capture file first!

A capture file is currently loaded so this file should be uploaded. This error occurs when a capture file is opened or after a live capture is performed most of the time but sometimes the upload does work correctly after closing Wireshark and reopening it and loading a capture file.

Once Wireshark has been opened and if the first capture uploads correctly then opening different capture files and uploading continues to work but if the first try doesn't work then opening new captures does not cause the plugin to work.

Is curl-ca-bundle.crt intentionally not shipped with 1.0.4?

I can't run the plugin. I edit the config file with the API, user and password, also I tried with the original config file without satisfactory results.
This is the issue:

Lua: Error during loading:
...al/lib/wireshark/plugins/wireshark-plugin/cloudshark.lua:1001: attempt to index global 'defaultConfigFile' (a nil value)
stack traceback:
	...al/lib/wireshark/plugins/wireshark-plugin/cloudshark.lua:1001: in main chunk

Right now the CloudShark plugin only works if it is in the Personal Plugins directory of Wireshark and fails to open the preference file if it is installed in the Global Plugins directory. Here is where we try and get the directory of our plugin:

https://github.com/cloudshark/wireshark-plugin/blob/master/cloudshark.lua#L185

This uses the persconffile_path function which returns the Personal Plugins directory so if it is in the Global Plugins dir we will still always look in the Personal Plugins dir:

https://wiki.wireshark.org/LuaAPI/Utils#Non_Method_Functions

Currently when uploading a capture file if you specify a new name for the capture file the upload does not use the new name and instead uses the default capture name. Looking at the logs and the debug output this is because it cannot create a file with the new name:

DEBUG: 12/10/15 10:52:42| Copy /Users/tom/.wireshark/plugins/cloudshark/wireshark-plugin-lua_mCH5Zw.cap to /Users/tom/.wireshark/plugins/cloudshark/tmp/new_name.pcap
DEBUG: 12/10/15 10:52:42| Unable to create new file /Users/tom/.wireshark/plugins/cloudshark/tmp/new_name.pcap

This is because the ~/.wireshark/plugins/cloudshark/tmp directory does not exist by default until the user creates it. If this directory exists then the capture is uploaded with the new name but we should be creating this directory in the plugin.