Comments (3)
No, I meant this https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/search?q=launch_template_version&unscoped_q=launch_template_version
from terraform-aws-ec2-autoscale-group.
@martinhanzik thanks!
Did you mean this https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/blob/master/main.tf#L99?
from terraform-aws-ec2-autoscale-group.
The module always deploys with the template version = 1. Even if launch_template has the latest version = 5
~ module.asg.aws_launch_template.default
latest_version: "5" => "0"
tag_specifications.0.tags.sourceCodeRef: "0ccb201" => "52e5bb1"
Terraform docs (With Latest Version Of Launch Template)
resource "aws_launch_template" "foobar" {
name_prefix = "foobar"
image_id = "ami-1a2b3c"
instance_type = "t2.micro"
}
resource "aws_autoscaling_group" "bar" {
availability_zones = ["us-east-1a"]
desired_capacity = 1
max_size = 1
min_size = 1
launch_template {
id = "${aws_launch_template.foobar.id}"
version = "$Latest"
}
}
But in your module launch_template version is a reference to terraform resource - aws_launch_template.default.latest_version - https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/blob/master/main.tf#L99. It looks right but does not work and does not comply with the Terraform documentation.
I think we can make a switch and use either the launch_template_version variable ("$Latest" or "$Default") - https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/search?q=launch_template_version&unscoped_q=launch_template_version or use terraform resource reference such as aws_launch_template.default.latest_version
from terraform-aws-ec2-autoscale-group.
Related Issues (20)
- Use non deprecated tag keys PR causes bug HOT 3
- Support for `instance_requrirements` in launch_template to create EC2 instances
- Remove deprecated output tags - alter to tag HOT 2
- Support for lifecycle hooks
- The variable `instance_initiated_shutdown_behavior` not allowed in the Launch Template when used for an EC2 Auto Scaling group
- Instance refresh missing properties (scale_in_protected_instances and standby_instances)
- Action Required: Fix Renovate Configuration
- Scaling policy type does not support all its possible values HOT 2
- Support terraform 0.15
- desired_capacity should be optional HOT 1
- iam_instance_profile_name tends to always update when doing a terraform apply
- Dependency Dashboard
- Mark object type attributes as optional if they're optional in aws provider HOT 1
- Remove deprecated provider `hashicorp/template` HOT 1
- Add option to create ECS cluster with ASG HOT 1
- Deprecated `tags` attribute on aws v4 provider HOT 1
- Expose metadata_options {instance_metadata_tags}
- launch_template_version $Latest does not trigger instance refresh when user-data or launch_tempate is updated. HOT 2
- IOPS is not currently working with EBS block mapping
- Missing `throughput` in block_device_mappings.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-ec2-autoscale-group.