Initial Implementation about terraform-aws-ec2-autoscale-group HOT 4 CLOSED

Resources sound good, except for not sure how we can leverage the DNS record with an ASG?

We should also define the outputs. I think they would be...

outputs

• security_group_id

variables

• instance_type
• namespace, stage, name, attributes, delimiter, tags - for label module
• subnet_ids
• ssh_key_pair

Note, the labels module will output tags_as_list_of_maps or something like that which is suitable for the autoscale group.

references

Refer to these modules/variables for inspiration:

• https://github.com/cloudposse/terraform-aws-ec2-instance-group/blob/master/variables.tf
• https://github.com/cloudposse/terraform-aws-ec2-instance/blob/master/variables.tf
• https://www.terraform.io/docs/providers/aws/r/autoscaling_group.html
• https://github.com/bitflight-public/terraform-aws-ecs-cluster/blob/master/ondemand-autoscaling/main.tf

Note, @Jamie-BitFlight has offered to donate any/all of his code under the bitflight-public repo to our cause, so feel free to borrow heavily against it @MoonMoon1919

from terraform-aws-ec2-autoscale-group.

That sounds good. I like that.

I was thinking the DNS record would be used only if enabled and an ELB and EIP was requested. Thoughts?

from terraform-aws-ec2-autoscale-group.

I think the ALB belongs outside of this module for greatest flexibility and re-use. For example, we're using these ALB modules for ECS, but they will work for many other use-cases.

Check these out:

• https://github.com/cloudposse/terraform-aws-alb-ingress
• https://github.com/cloudposse/terraform-aws-alb
• https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms

Perhaps the module can take as an input the target groups ARNs and use the aws_autoscaling_attachment resource in the autoscale module to attach to those arns. This will let you use the alb-ingress module to route traffic to that ARN.

https://www.terraform.io/docs/providers/aws/r/autoscaling_attachment.html

from terraform-aws-ec2-autoscale-group.

I like that, sounds good!

from terraform-aws-ec2-autoscale-group.