Headings and Notes hidden about cloudfour.com-patterns HOT 9 CLOSED

@nicolemors Could you have accidentally used any of the toggle shortcuts? @erikjung added keyboard commands to toggle these elements: https://github.com/cloudfour/cloudfour-redesign/blob/master/src/assets/fabricator/scripts/fabricator.js#L7-L10

from cloudfour.com-patterns.

@tylersticka I wonder though if this highlights a potential UX gotcha over time. Like, what if this happens to a client? The keyboard shortcuts are easter eggs, but non-obvious when they're triggered, potentially. Eh.

from cloudfour.com-patterns.

Well first, I'd like to hear from @nicolemors if that was actually the problem or not.

If so, I'd pitch this back to @erikjung. My idea was to simply remove these features... I don't find them useful. @erikjung did, and suggested keyboard shortcuts as a compromise.

from cloudfour.com-patterns.

It was was the keyboard shortcuts. It wasn't obvious to me at all that I had triggered them. Are the toggled off by default?

from cloudfour.com-patterns.

@erikjung I've also been noticing that some elements are hidden when I first start up Fabricator, and it's unclear how to hide them again. Assigning this to you so we can revisit this functionality... if it's not working well, my instinct would be to either fix it or comment it out until we feel like devoting energy to it.

from cloudfour.com-patterns.

@tylersticka I'll dig into this later in the week. If I recall correctly, the settings for which things should be shown/hidden are stored client-side (cookie or localStorage or something.) This was a pre-existing feature before the key commands were added. Maybe this is part of the cause for stuff being hidden by default. I wonder if this persistence is even needed?

I also wonder if this issue would be better addressed in our Fabricator fork.

from cloudfour.com-patterns.

I'd also be fine with just removing this functionality altogether here (in this repo)....and then maybe doing the same in Fabricator later on. I don't care as much anymore.

from cloudfour.com-patterns.

I guess I would like it if the code samples were hidden by default (since you can click to toggle that) but everything else was showing. I'd be happy with that and none of the hide/show functionality as a stop-gap, then fixing the main issue in the other repo.

from cloudfour.com-patterns.

Maybe we could even use :target for that.

from cloudfour.com-patterns.