Upload of app/buildpack bits reports success even if server failed about cli HOT 4 CLOSED

I now understand the use of callback in TempFile is to ensure the defer code is not run until after the callback has completed. Without the callback, the defer code is run as soon as the function returns, so the temp file is deleted before it is used... making the file a bit too temporary.

from cli.

I think my diagnosis is off - the deferred callback doesn't complete asynchronously as I thought.

However, the fact remains, apiResponse is set to the correct value in the callback, but is blank when then returned causing errors to be ignored.

from cli.

Found the underlying issue - and it was limited to how buildpack.uploadBits was reassigning apiResponse in one of its calls. PR #61 submitted to fix.

from cli.

Fixed by #49

from cli.