Code Monkey home page Code Monkey logo

Comments (6)

thansmann avatar thansmann commented on June 22, 2024

Hi @sykesm - do you have a script and fixtures to reproduce? This is going into CLI icebox, and it'll be easier to get to if we can get it repro'd quickly.

cc: @scottruitt

from cli.

scottruitt avatar scottruitt commented on June 22, 2024

@thansmann and @sykesm --

@tedsuo and I reviewed it. It's a legit issue, but one we probably won't tackle immediately. I'll prioritize this in the backlog.

Scott

from cli.

XenoPhex avatar XenoPhex commented on June 22, 2024

It is undesirable to make unnecessary HTTP requests to product a single set of data. That truth should be self-evident.

Unfortunately, due to the nature of the CC API, we made the explicit choice to make requests for resources with inline-relations-depth=1 in all cases. It's a little complicated, but if you're interested we could explain it in more detail.

The short answer is that doing this helps us know (at compile time) that we're using the API correctly. A longer answer would probably address that this is a hack but that it's a useful hack that makes our code (and api) less complex and thus easier to reason about.

Feel free to continue commenting on this issue if you'd like to discuss it. It is unlikely that we would drastically change our internal API model (barring some features or new API that drove out these changes), so we'd like to consider this as closed.

from cli.

sykesm avatar sykesm commented on June 22, 2024

@XenoPhex the next time I'm in SF (end of the month) I'd welcome a discussion around inline-relations-depth=n. There are a number of scenarios where it makes a great deal of sense - even here. That said, it doesn't make make a lot of sense to me to get the data a second time when when you know you got it the first time.

from cli.

XenoPhex avatar XenoPhex commented on June 22, 2024

Cool! Come on down!
Barker all the way

from cli.

sykesm avatar sykesm commented on June 22, 2024

OMG! I won! :)

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.