Request: BBL_STATE_DIR calculates full(er) path about cf-deployment-concourse-tasks HOT 8 CLOSED

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/150113066

The labels on this github issue will be updated when the story is started.

from cf-deployment-concourse-tasks.

It looks like the critical line here is:

  export BBL_STATE_DIR=${root_dir}/bbl-state/${BBL_STATE_DIR}

Essentially, our Concourse task would allow users to set their BBL_STATE_DIR to be relative to the bbl-state input, but we'd expand the relative path to the full path (based on the root_dir of the concourse build).

In that case, what does bbl expect BBL_STATE_DIR to look like -- a relative path or an absolute one? In the workflow you described, where a user copies the variables in their pipeline yaml, would bbl still be able to respect the relative path defined there?

from cf-deployment-concourse-tasks.

@evanfarrar Hey, any updates on this?

from cf-deployment-concourse-tasks.

Hey, sorry I missed this:

The BBL_STATE_DIR in bbl is fine being relative or absolute, we only expand it in the concourse task to incorporate the "bbl-state" parent directory scheme that cf-deployment-concourse follows. It could be expanded less fully in the task, if you prefer.

from cf-deployment-concourse-tasks.

Hey @evanfarrar. This sounds reasonable. I've updated the story:

Title:
As a Concourse user, I want the bbl-up task to expand BBL_STATE_DIR to a full path so that, eventually, bbl can use the value natively.

Acceptance Criteria:

• BBL_STATE_DIR should be converted into a full path early on in the script, a la BBL_STATE_DIR=${root_dir}/bbl-state/BBL_STATE_DIR
• Subsequent uses of BBL_STATE_DIR should be not have the bbl-state namespace as in this line:

  cf-deployment-concourse-tasks/bbl-up/task

  Line 97 in fb6137f

  pushd "bbl-state/${BBL_STATE_DIR}"

How does that look?

from cf-deployment-concourse-tasks.

I have not answered this in forever but, that looks great.

from cf-deployment-concourse-tasks.

Yo @evanfarrar, do we still need to do this since the release of bbl 5? If so, I'll prioritize it.

from cf-deployment-concourse-tasks.

Hey, I'm going to close this out since I don't think we need to do this after all. Feel free to re-open it if you think this would still be valuable.

from cf-deployment-concourse-tasks.