Code Monkey home page Code Monkey logo

Comments (3)

ghedo avatar ghedo commented on August 29, 2024

One problem is that the TLS handshake state (which is a raw pointer to a BoringSSL SSL object) is not thread-safe, which makes the whole Connection not thread-safe as well. It might be possible to make it thread-safe by wrapping the TLS state in Arc<Mutex<...> but that would need to be tested to make sure it doesn't break any assumptions made by BoringSSL.

from quiche.

puckipedia avatar puckipedia commented on August 29, 2024

I believe impling Send would be safe on both Context and Handshake, as that just means allowing the respective structs to move between threads, which is okayed by the ssl.h comments:

// An |SSL| object represents a single TLS or DTLS connection. Although the
// shared |SSL_CTX| is thread-safe, an |SSL| is not thread-safe and may only be
// used on one thread at a time.

from quiche.

ctiller avatar ctiller commented on August 29, 2024

One would also need to deal with application data on streams - currently this is a Box<dyn std::any::Any> and it would need to be Box<dyn Send + std::any::Any>, which would break the current ffi interface, since it's taking a *mut c_void for application data, which is not Send.

from quiche.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.