Support for fully offline search like PWAs about pagefind HOT 7 OPEN

I'm not particularly on top of PWAs, but I could definitely add an option for configuring that query parameter. That would let you specify a custom query parameter rather than using the timestamp automatically, but would still allow you to set a new parameter on each build if you ran into caching issues. I'll wire that up 🙂

from pagefind.

Grand! I'll include that in the next release.

from pagefind.

Hi @geshan — unfortunately there wasn't a super simple way to drop this in with the latest release. This file is loaded on initialization before any options get passed to Pagefind in the browser, so there isn't a great way to connect this to a flag in a nice way. (and I'm hesitant to make it a build-time flag)

For now, after running pagefind you could automatically patch out that query parameter each time:

# Linux
pagefind && sed -i 's/?ts=${Date.now()}//g' public/_pagefind/pagefind.js

# MacOS
pagefind && sed -i '' 's/?ts=${Date.now()}//g' public/_pagefind/pagefind.js

I will keep ruminating on this though and try find a better solution that I'm comfortable with 🙂

from pagefind.

Ah, I had forgotten about this issue but I'll pencil in proper support soon! As of Pagefind 1.0, the file is not loaded on initialization, and passing options could totally influence this behavior, so I can certainly add an option to resolve this. I'll target the next release for that 🙂

from pagefind.

@bglw that would be really helpful, then I can replace my google search with Pagefind and it will work fully offline too.

from pagefind.

Sounds fine for now, thanks!

from pagefind.

Hi @geshan — unfortunately there wasn't a super simple way to drop this in with the latest release. This file is loaded on initialization before any options get passed to Pagefind in the browser, so there isn't a great way to connect this to a flag in a nice way. (and I'm hesitant to make it a build-time flag)

For now, after running pagefind you could automatically patch out that query parameter each time:

# Linux
pagefind && sed -i 's/?ts=${Date.now()}//g' public/_pagefind/pagefind.js

# MacOS
pagefind && sed -i '' 's/?ts=${Date.now()}//g' public/_pagefind/pagefind.js

I will keep ruminating on this though and try find a better solution that I'm comfortable with 🙂

It works for now and also works in GitHub Workflows. And yes, it needs a better solution.

from pagefind.