HTML entities in search results about pagefind HOT 14 CLOSED

Thank you so much for the quick response, and this pagefind thing is awesome. ❤️

from pagefind.

I guess the fix is to change {data.meta?.title} to {@html data.meta?.title} in pagefind_ui/svelte/result.svelte

from pagefind.

For now I have fixed this for myself by monkeypatching the JS bundle, so you will not see the issue on my site as I described above. (I was keen to get it working!)

from pagefind.

Ah, yep good spot. I'll get that released for you this week.

from pagefind.

I have a similar issue but I'm not sure if it's 100% the same.
I have a blog post that starts with "I'm joining" and gets displayed via Pagefind as "I'm Joining". I'm having trouble debugging the issue but could this also be resolved with the {@html fix mentioned by @fanf2 ? It's also a title problem.
Thanks!
Heard about the tool in HugoConf and keen to replace Lunr.js as the index file started to clog up! Cheers!

from pagefind.

Hi @wgroeneveld — yes that looks like the same issue, but I'll make sure to test it directly before the next release.

from pagefind.

Hi @fanf2 and @wgroeneveld 👋

Fixes for HTML entities have been released in Pagefind v0.5.0 🎉

from pagefind.

Hi @fanf2 and @wgroeneveld 👋

Fixes for HTML entities have been released in Pagefind v0.5.0 🎉

Awesome thanks!

from pagefind.

I still have this happen in Pagefind 1.0.3.

from pagefind.

For example, using this markup:

<h2 data-pagefind-meta="title"><span class="title">Faster &#34;shuffle&#34;</span></h2>

from pagefind.

Ah, my mistake, I did regress this in 1.0. 

We need to avoid rendering some things as HTML (for example, on MDN where pages are titled the <aside> element — but in resolving that I have reintroduced the title display error from this issue.

I'll get this re-fixed up for the next release — sorry about that.

(The indexing bug has not been introduced, just the display bug)

from pagefind.

In the meantime, PagefindUI's processResult hook could be used to normalize the titles before display.

from pagefind.

This seems to work, there might be a more elegant way to unescape:

      new PagefindUI({
          element: "#search",
          showSubResults: true,
          resetStyles: false,
          processResult: function (result) {
              var title = new DOMParser().parseFromString(result.meta.title, "text/html");
              result.meta.title = title.documentElement.textContent;
              return result;
          }
      });

from pagefind.

I was about to write a larger note about how I cannot reproduce this, but it only seems to apply if you're using a custom data-pagefind-meta="title" attribute. The automatic h1 title capture works fine — so that will make the fix simpler (and also means this doesn't affect most sites).

(example: searching greater than on https://mdn.pagefind.app/)

That processResult looks fine to me! At least as a temporary stop-gap 🙂

from pagefind.