iOS VPN: ViewController Architecture Problem about newnode HOT 2 OPEN

That UI oddity is possibly something more intentional than a bug. It's confusing because of the way the UI appears.

NewNode has an internal state of whether it is "enabled" or not. This is the user preference. It used to be represented with a toggle switch, which would only move when the user tapped it.

Independently, the OS has a notion of whether the VPN is "in use", represented as "Connected"/"Disconnected" in the UI.

So, it makes sense to have NewNode "enabled" but "disconnected", meaning the user wants to use NewNode when possible, but right now it's not possible.

(There's a further state one might call "Connected", regarding whether NewNode can reach peers, but this is not represented in the button or the status message.)

from newnode.

I think we could fix it by adding a double-check for the VPN switch enabled in preferences.
The scenario is following:

• User turns on the NewNode VPN
• User switches to another VPN and turns it on
• The NewNode VPN manager in preferences becomes disabled
• User switches back to NewNode VPN
• The .willEnterForegroundNotification performs connect
• startVPNTunnel throws the .configurationDisabled error
• Re-enable the manager and save it to preferences
• Call startVPNTunnel again

from newnode.