Supporting `:module-type` compiler option about boot-cljsjs HOT 10 CLOSED

It doesn't solve this, it works around this.

I'd still prefer solution which doesn't involve calling npm and instead packages the files to JARs.

from boot-cljsjs.

@shaunlebron this sounds great, I assume this doesn't have any impact on externs (i.e. they're still required)?

from boot-cljsjs.

Externs are no longer required in this case. The CommonJS/AMD/ES2015 module gets converted into a Google Closure Compiler module and can be consumed as such.

from boot-cljsjs.

Blocked by: http://dev.clojure.org/jira/browse/CLJS-1762 and probably other bugs will be found once Closure compiler has been updated.

Currently module-type support is not good for other than very simple tests cases. For example npm modules can't be used.

from boot-cljsjs.

Now that there's :module-type support in ClojureScript since 1.9.454 (https://clojurescript.org/reference/javascript-module-support) would the be interest to support this option in cljsjs?

from boot-cljsjs.

Closure/ClojureScript doesn't currently support Node module resolution in classpath (e.g. Cljsjs JARs). Either files would need to be copied to filesystem in Cljs compiler, or something (Cljs, Cljsjs) should provide Closure node module resolution implementation which works with classpath.

from boot-cljsjs.

I see, thanks.

from boot-cljsjs.

Does the :npm-deps option solve this now?

from boot-cljsjs.

Also, when using :npm-deps, it doesn't make much sense to provide those in packages, it is easy for user to declare :npm-deps in the project. But for this use case we could provide separate externs packages.

from boot-cljsjs.

I don't think there is anything to do related to Cljsjs here. Deps.cljs can be generated with :module-type entries, but I think ClojureScript compiler and Closure only work if those files are available in filesystem, not classpath. This will need to be fixed elsewhere.

from boot-cljsjs.