Comments (8)
Although I dev on Ubuntu/Linux, we discovered this issue when my colleagues tried to build a package on their Windows 7 box. The build complains about not being able to delete the downloaded zip, and fails when sift regex has forward slashes in the path.
We are happy to be guinea pigs for testing any proposed fixes.
from boot-cljsjs.
As an example.
With clsjs/codemirror the example sifts provided do not work on Windows:
(sift :add-jar {'cljsjs/codemirror #"cljsjs/codemirror/common/codemirror.css"})
(sift :move {#"cljsjs/codemirror/development/codemirror.css" "vendor/codemirror/codemirror.css"})))
My first attempt made them only work on Windows:
(sift :add-jar {'cljsjs/codemirror #"^cljsjs\\codemirror\\development\\codemirror.css$"})
(sift :move {#"^cljsjs\\codemirror\\development\\codemirror.css$" "vendor/codemirror/codemirror.css"})
Something like this should work for both:
(sift :add-jar {'cljsjs/codemirror #"^cljsjs.codemirror.development.codemirror.css$"})
(sift :move {#"^cljsjs.codemirror.development.codemirror.css$" "vendor/codemirror/codemirror.css"})
Or even this:
(sift :add-jar {'cljsjs/codemirror #"^cljsjs[/ \\]codemirror[/ \\]development[/ \\]codemirror.css$"})
(sift :move {#"^cljsjs[/ \\]codemirror[/ \\]development[/ \\]codemirror.css$" "vendor/codemirror/codemirror.css"})
from boot-cljsjs.
@micha do you have any thoughts on this? A solution to this probably belongs more into Boot itself than into boot-cljsjs
.
from boot-cljsjs.
Any chance to have a "lein" version of this project?
Thank you.
from boot-cljsjs.
@aadrian What do you mean? I don't see need for such and many features here are built tightly on top of Boot's features. Thus I doubt Cljsjs maintainers have interest in providing such version.
from boot-cljsjs.
What do you mean?
The number of JS Libs covered on https://cljsjs.github.io/ is just too small, and judging from the number of open requests and their completion time, I would say that it's a huge task.
So if the users could more easily make and not just request JS lib support, the project would be even more useful.
Most users already using Lein, won't switch just to be able to maintain and submit "cljsjs"s :).
from boot-cljsjs.
If you want to discuss this more, please create a separate issue.
I doubt Boot is the cause for number of packages or slow packaging time, most work when packaging a library goes into creating the extern file which is often manual work. Boot is also already used by good part of Clojure community (13% in December and I have a feeling that the growth rate has accelerated since then).
from boot-cljsjs.
... most work when packaging a library goes into creating the extern file which is often manual work.
Exactly :). So in the context of a working project that is already using a particular JS lib (or more) the "old way", for "87% of the users :)" it would be easier to just configure the extra file and submit it. Since it's part of the project that is already using those resources, is also the best test case.
The alternative (now in use use) would be to build another project with another build tool (that the user also needs to learn and master first), test it and just than submit it :).
from boot-cljsjs.
Related Issues (20)
- Provide a way to have multiple externs HOT 3
- Browserified npm modules HOT 4
- Allow users to specify additional provides clauses HOT 3
- Trouble with tasks for DraftJS HOT 1
- Provide Extern generation task
- npm task HOT 5
- Sanity check task HOT 1
- Replace content fails on Windows HOT 2
- The minify task doesn't seem to work on Windows HOT 1
- Downloaded file cannot be deleted in Windows HOT 3
- Mark is not supported HOT 2
- D3 externs error HOT 1
- deps-cljs task produces invalid deps.cljs on Windows (backslashes in :externs array)
- Incorrect handling of tgz archives HOT 8
- Weird directory structure HOT 1
- Invalid cookie header when fetching zip from git
- Minifying es6 HOT 3
- validate-checksums doesn't see files from minify task
- ClassNotFoundException on Java 12 HOT 3
- it is valid for :global-exports key to be a string HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from boot-cljsjs.