Code Monkey home page Code Monkey logo

Comments (5)

jjtolton avatar jjtolton commented on July 1, 2024

Can we rule out that this is unrelated?
https://bugs.python.org/issue34760

from libpython-clj.

cnuernber avatar cnuernber commented on July 1, 2024

No, I think it is related. The pandas code is calling isinstance and it appears like the abc code itself is just generically forwarding to issubclass and that is a bug.
That being said, I bet if the iterator derives from ABC.Iterator that would make this issue go away.

from libpython-clj.

jjtolton avatar jjtolton commented on July 1, 2024

I think in this case it's fine to wrap iterators with abc.Iterator, but should be careful of:

  1. providing overly specific generic wrappers to Python and
  2. not try to fix Python (or Clojure's bugs) -- I think that could bite us when they fix them later

from libpython-clj.

cnuernber avatar cnuernber commented on July 1, 2024

Agreed on both counts.

from libpython-clj.

cnuernber avatar cnuernber commented on July 1, 2024

https://github.com/cnuernber/libpython-clj/releases/tag/1.28

from libpython-clj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.