Code Monkey home page Code Monkey logo

Comments (1)

KingMob avatar KingMob commented on June 3, 2024

First, given there's no conversion of the wrapped byte type, you should probably reach for Manifold's stream->seq fn instead of convert.

I think the docstring for convert could be a bit clearer on this, but it does mention that if the input is a stream, the stream contents must be specified.

What's missing in the docstring is the option key to accomplish this. FWIW, the option is :source-type, e.g., (convert content (seq-of bytes) {:source-type (stream-of bytes)}).

I also think returning the original input unchanged instead of throwing an IllegalArgumentException (like it says in the docstring) is a bug, but I need to make sure any fix doesn't break identity transformations. I'll have a PR soon.

from byte-streams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.