Comments (3)
One thing we could do is stick all internal keys in a map under a single key, like:
{:headers {...}
:body ...
:aleph/keep-alive? true
:aleph/request-arrived some-nano-time
:aleph/internal {:ch ch
:gory-internal1 ...
:gory-internal2 ...}}
I think it's nice and tidy this way.
from aleph.
I think I slightly prefer the flat version because looking up a single internal key is more convenient then (most usage sites are only interested in one of them at a time I think). But the submap approach has the nice advantage that endusers can just dissoc
that single key to rid the request map of the gory internals, so there's that.
Another alternative could be to store these in metadata (cf. how it's done for :aleph/channel
on streams in the UDP, TCP and websocket implementations).
from aleph.
Flat version is fine, I don't care that much.
Please do not store them in metadata though. I've been wanting to remove that behavior because it violates expectations about what metadata is, and what it's attached to.
from aleph.
Related Issues (20)
- Please bump netty versions because of CVE-2023-34462 HOT 1
- Enable endpoint identification (aka hostname verification) for TLS clients by default? HOT 9
- Look into new Ring websocket support for Aleph HOT 2
- Add write backpressure by checking Channel writability
- Add support for aggregating all inbound data before calling server Ring handler HOT 2
- Default rejected-handler will leak buffers in raw stream HTTP servers HOT 1
- Overhaul docstring formatting for consistency HOT 2
- Hide application protocol config from users with `http-versions`
- Who uses Aleph? Add your name to this, we'd like to know HOT 4
- io.netty.channel.AbstractChannelHandlerContext invokeExceptionCaught HOT 2
- 0.7.0-rc1 is crashing without brotli4j dependency #3530 HOT 2
- Treat de/compression asymmetrically in H2
- Track down potential idle-handler refcount testing leak HOT 11
- Question about single server process using both non-ssl and ssl HOT 3
- Support cancellation of HTTP requests HOT 2
- HTTP client connection pool timeout doesn't free up queue HOT 4
- Drop HTTP client connection pool's acquire queue HOT 1
- CVE-2024-29025 HOT 5
- No ssl-context via `SslContext` in Aleph 0.7.0 and later HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aleph.