Code Monkey home page Code Monkey logo

Comments (34)

berkona avatar berkona commented on May 13, 2024

I feel like there's some weird string encoding going on here as python2 is famous for its inconsistent handling of strings. Then again, it could be some sort of non-printable unicode character causing the final part to be reversed. Or possibly some regex issue (i.e., needs escaping). I need to look at that code again to see if this is actually the case.

EDIT: It would be useful to know what version of the script you're running :)

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

It's pretty simple, QoQ (poster, big in here in Holland) is using reversed names for protection (so that automatic tools, can't "destroy" the post). So the reversed name is normal when you download the file ;)

I'm running (of course) the latest git version.

from nzbtomedia.

berkona avatar berkona commented on May 13, 2024

Ah I see now. @clinton-hall what if we try to process the file normally and then try reversing the filename and processing again as a last ditch in case this becomes common practice.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Yeah, the issue here is these logs are from CouchPotato, not this script?
I don't know of any recursive scan of name in the TorrentToMedia or nzbTo* scripts...

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

No these are from sickbeard, the post processing script ;)

Altough I'm not sure if this is sickbeard related or post processing related...

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

I believe this is sickbeard related...

The names that we pass on are the names of the actual torrents/nzbs etc. It is very difficult for us to intervene and change these..

we do get a return result from sickbeard, so we could try renaming and sending again.... but this would just be a "guess"... the problem is getting an automated way to determine the mode of failure in SB and then change accordingly.

Can you provide the actual logs from the postprocess script... I think we can actually do a check for torrent name/nzb name in directory, and reverese torren name/nzb name in directory... if the reverse matches, we pass the reverse...

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

This is the whole log file:

nzbToSickBeard V5.1
Script triggered from SABnzbd, starting autoProcessTV...
Loading config from /home/user/scripts/autoProcessMedia.cfg
The download succeeded. Sending process request to SickBeard's failed branch
Opening URL: http://localhost:8081/home/postprocess/processEpisode?nzbName=The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs+%5B%3D-%3C+Q+o+Q+%3E-%3D%5D.nzb&failed=0&dirName=%2Fmedia%2Fnas%2FDownloads%2Ftmp%2FThe.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs+%5B%3D-%3C+Q+o+Q+%3E-%3D%5D&quiet=1
Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]

Recursively processing a folder: M1080f1d9df91d2bf3d8s3e11

Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11

Recursively processing a folder: LEES DIT

Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/LEES DIT

Processing /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv (None)

Parsed QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]

Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW

Looking up QoQ-sbusLN 462x LD-BEW in the DB

Looking up name QoQ-sbusLN 462x LD-BEW on TVDB

Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB

Parsed /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]

Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW

Looking up QoQ-sbusLN 462x LD-BEW in the DB

Looking up name QoQ-sbusLN 462x LD-BEW on TVDB

Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB

Parsed M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]

Checking scene exceptions for a match on M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW

Looking up M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW in the DB

Looking up name M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW on TVDB

Looking up name M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW in all languages on TVDB

Processing failed for /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv: 

Remember, the name
QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv
is correct, this is done by QoQ them selfs.

I was thinking, if the post processing script is reading the name, why can't it ID the QoQ-sbus(< this is always the same) and if it finds that, reverse it?

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Yep, can do that.. I thought this was an issue with torrent... First time I've ever seen this in nzbs.
I thought the issue was actually in the name that we passed... But the name is correct, it is the file name that is reversed... So we actually need to do a rename before we pass this to SickBeard... A bit more work... But I'll try and get something in to the dev branch in the next few days.

Thanks for logs... I was about to make major changes in torrent scripts that would have been messy!

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

Sorry man! In holland QoQ is well known for the nzb releases, I forgot that foreigners didn't know about QoQ, my bad! And thanks already, happy to help you debug this!

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

oeps, sorry I didn't meant to close it.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Do QoQ only do .mkv releases, or do they do avi etc as well?
Do they reverse the naming in all files. Eg nfo etc.?
Do they ever have multiple parts (cd1, cd2) and if so, where in the name do these occur?
Do they only do TV, or do they do movies as well?

A lot of questions, but I want to make sure I do this right, not just a quick fix.

from nzbtomedia.

ajongsma avatar ajongsma commented on May 13, 2024

Hi, just wanted to add something to this conversation.

NewzNAB solves these issues with, if I remember correctly, the update_parser.php with something like:
if(strpos($searchname, 'QoQ-sbuSLN') !== FALSE) {
$searchname = strrev($searchname);
}

Sorry, not behind my box at home so it might not be completely accurate but I hope it gives you an idea :)

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

I already made a costum script that changed the name in newznab, we're talking here about the filename, this is AFTER you downloaded the NZB. So not sure why you dres this up?
@clinton-hall in mine parsing script I use:

preg_match('/( )?(\.wmv|\.divx|\.avi|\.mkv)/i'
  1. They do only reverse names of the movie or tv show file.
  2. Not sure about the multiple parts since I mostly download .mkv files, I do see sometimes that they post dvd files, but there name (of the dvd filenames) aren't reversed since they are common dvd filenames (VOB_01 etc)
  3. QoQ is posting TV and Movie releases (all sorts of quality, I only download the HD ones)

This is a release of them: (they do not use NFO files)
Naamloos
Now bear in mind, the M1080f1d9df91d2bf3d8s3e11 is already changed, we're only looking at the .mkv in this case.

from nzbtomedia.

ajongsma avatar ajongsma commented on May 13, 2024

Sorry to keep meddling in but I checked update_parsing.php by now. Line #143 - #149:
//QoQ releases
if (preg_match('/^QoQ-(.*)$/', $rel['name']))
{
$foundName = strrev( $rel['name'] );
$methodused = "QoQ";
determineCategory($rel,$foundName,$methodused);
}

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

@ajongsma Yeah that is the old parsing thing, you can delete that, that is just messing with your database. I made a new one.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Thanks for the details... I should have a fix in dev soon.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Should now be resolved.
I have left this section of the code open to adding more group customizations in the future... for now, if nzbname contains "QoQ" it will parse the directory, find the video files (not including .vob) and reverse the file name (leaving the extension correct).

Only in dev branch at this time... please let me know if you have any problems with this.

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024
Processing folder /media/nas/Downloads/tmp
Recursively processing a folder: The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]
Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]
Recursively processing a folder: M1080f1d9df91d2bf3d8s3e11
Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11
Recursively processing a folder: LEES DIT
Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/LEES DIT
Processing /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv (None)
Parsed QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]
Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW
Looking up QoQ-sbusLN 462x LD-BEW in the DB
Looking up name QoQ-sbusLN 462x LD-BEW on TVDB
Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB
Parsed /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]
Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW
Looking up QoQ-sbusLN 462x LD-BEW in the DB
Looking up name QoQ-sbusLN 462x LD-BEW on TVDB
Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB
Parsed M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv into M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW - S8E1 - 01E30S.daed.gniklaW.ehT [ABD: False]
Checking scene exceptions for a match on M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW
Looking up M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW in the DB
Looking up name M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW on TVDB
Looking up name M1080f1d9df91d2bf3d8s3e11 QoQ-sbusLN 462x LD-BEW in all languages on TVDB
Processing failed for /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv: 

Not working, this is the log. And yes I'm on the dev branch.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Ah... The actual nz name that gets passed is structured [=-< Q o Q >-=] but I am just searching for "QoQ"
Will have to change this and do some more testing.

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

Euhm I don't have a lot of knowledge, but aren't you searching for this:

QoQ-sbusLN.462x.LD-BEW.0801.01E30S.daed.gniklaW.ehT.mkv

the filename?

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

No... I was searching in the nz name first to avoid having to parse all the files names on other downloads

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Just made another change... Test that out.
If it still causes issues I might have to match QoQ in file name, but I really want to avoid parsing file names for other downloads if I can....

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

For some odd reason I can't seem to get the filename backwards again. how can I test the script manualy witouth download it trought sab everytime?

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

To test it, you would need to put the files back into their original location with the original name etc...
Then you need to run the postprocess script, passing in the same directory, nzbname, and status as was passed in by sabnzbd.

e.g.
./nzbToSickBeard.py "/media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]" "The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=].nzb" 0

check the sabnzbd logs... they might actually show the parameters that were passed.

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

Oke so I dubbled checked and the name of the mkv was reversed and changed by the script (nice 👍 ) so it's working for me! (only thing is that I already downloaded it so it isn't moving it, but that's np)

10:28:41|INFO    nzbToSickBeard V5.1
10:28:41|INFO    Script triggered from NZBGet, starting autoProcessTV...
10:28:41|INFO    Loading config from ./autoProcessMedia.cfg
10:28:41|INFO    The download succeeded. Sending process request to SickBeard's failed branch
10:28:41|INFO    Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/

10:28:41|INFO    Recursively processing a folder: M1080f1d9df91d2bf3d8s3e11

10:28:41|INFO    Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11

10:28:41|INFO    Recursively processing a folder: LEES DIT

10:28:41|INFO    Processing folder /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/LEES DIT

10:28:41|INFO    Processing /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv (None)

10:28:41|INFO    Parsed The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv into The Walking dead - S3E10 - 1080.WEB-DL.x264.NLsubs (QoQ) [ABD: False]

10:28:41|INFO    Checking scene exceptions for a match on The Walking dead

10:28:41|INFO    Looking up The Walking dead in the DB

10:28:41|INFO    Lookup successful, using tvdb id 153021

10:28:41|INFO    Loading show object for tvdb_id 153021

10:28:41|INFO    Retrieving episode object for 3x10

10:28:41|INFO    Looking up quality for name M1080f1d9df91d2bf3d8s3e11, got Unknown

10:28:41|INFO    Looking up quality for name The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv, got Unknown

10:28:41|INFO    Guessing quality for name The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv, got HD TV

10:28:41|INFO    Is ep a priority download: False

10:28:41|INFO    File /media/nas/Downloads/Serie/The Walking Dead/the walking dead/Season 3/Episode 10 - Home/the walking dead - 3x10 - home - 1080p.WEB-DL - MiND.mkv is larger than /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv

10:28:41|INFO    File exists and we are not going to replace it because it's not smaller, quitting post-processing

10:28:41|INFO    Processing failed for /media/nas/Downloads/tmp/The.Walking.Dead.S03E11.1080p.WEB-DL.AAC2.0.H.264-NLSubs [=-< Q o Q >-=]/M1080f1d9df91d2bf3d8s3e11/The.Walking.dead.S03E10.1080.WEB-DL.x264.NLsubs-QoQ.mkv:

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Thanks for the confirmation.

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

This is weird I downloaded the latest episode of Walking dead again:

22:04:30|INFO    nzbToSickBeard V6.0
22:04:30|INFO    Script triggered from SABnzbd, starting autoProcessTV...
22:04:30|INFO    Loading config from /home/user/scripts/autoProcessMedia.cfg
22:04:30|INFO    The download succeeded. Sending process request to SickBeard's failed branch
22:04:32|INFO    Processing folder /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)

22:04:32|INFO    Recursively processing a folder: M1080f1d9df91d2bf3d8s3e12

22:04:32|INFO    Processing folder /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)/M1080f1d9df91d2bf3d8s3e12

22:04:32|INFO    Recursively processing a folder: LEES DIT

22:04:32|INFO    Processing folder /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)/M1080f1d9df91d2bf3d8s3e12/LEES DIT

22:04:32|INFO    Processing /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)/M1080f1d9df91d2bf3d8s3e12/QoQ-sbusLN.462x.LD-BEW.0801.21E30S.daed.gniklaW.ehT.mkv (None)

22:04:32|INFO    Parsed QoQ-sbusLN.462x.LD-BEW.0801.21E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 21E30S.daed.gniklaW.ehT [ABD: False]

22:04:32|INFO    Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW

22:04:32|INFO    Looking up QoQ-sbusLN 462x LD-BEW in the DB

22:04:32|INFO    Looking up name QoQ-sbusLN 462x LD-BEW on TVDB

22:04:32|INFO    Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB

22:04:32|INFO    Parsed /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)/M1080f1d9df91d2bf3d8s3e12/QoQ-sbusLN.462x.LD-BEW.0801.21E30S.daed.gniklaW.ehT.mkv into QoQ-sbusLN 462x LD-BEW - S8E1 - 21E30S.daed.gniklaW.ehT [ABD: False]

22:04:32|INFO    Checking scene exceptions for a match on QoQ-sbusLN 462x LD-BEW

22:04:32|INFO    Looking up QoQ-sbusLN 462x LD-BEW in the DB

22:04:32|INFO    Looking up name QoQ-sbusLN 462x LD-BEW on TVDB

22:04:32|INFO    Looking up name QoQ-sbusLN 462x LD-BEW in all languages on TVDB

22:04:32|INFO    Parsed M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN.462x.LD-BEW.0801.21E30S.daed.gniklaW.ehT.mkv into M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN 462x LD-BEW - S8E1 - 21E30S.daed.gniklaW.ehT [ABD: False]

22:04:32|INFO    Checking scene exceptions for a match on M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN 462x LD-BEW

22:04:32|INFO    Looking up M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN 462x LD-BEW in the DB

22:04:32|INFO    Looking up name M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN 462x LD-BEW on TVDB

22:04:32|INFO    Looking up name M1080f1d9df91d2bf3d8s3e12 QoQ-sbusLN 462x LD-BEW in all languages on TVDB

22:04:32|INFO    Processing failed for /media/nas/Downloads/tmp/THE WALKING DEAD (2013) S03E12 x264 (WEB-DL) 1080p NLSubs _=-_lt_ Q o Q _gt_-=_ (1)/M1080f1d9df91d2bf3d8s3e12/QoQ-sbusLN.462x.LD-BEW.0801.21E30S.daed.gniklaW.ehT.mkv: 

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

I noticed that the future is removed? @berkona
140926e

After reverting to this:
0a3a249
It's working again.

(I'm still runing the dev branche, yes)

from nzbtomedia.

berkona avatar berkona commented on May 13, 2024

@clinton-hall does nzbName need to be changed after we change a filename?

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

shouldn't need to.
In fact the nzbName in this case is around the correct way.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

yeah.. a couple of bugs crept in when we moved functions to their own modules...

I have fixed this in the refactor0.7 branch... which we will probably be merging into dev soon.

This gave me a good excuse to test and make a few fixes in this refactor branch.

This now just searches for "Q o Q" in the filename or the nzbName. I also added a safe name conversion as the folder can't be named [=-< Q o Q >-=] in windows as the "<" and ">" are not permitted in folder or file names!!!
Hence now testing for just Q o Q... if this becomes a problem, please let me know.. I have "safeName" function that we could use to convert the [=-< Q o Q >-=], the directory and the nzbName... but needs a few more "imports" so hoping "Q o Q" is enough.

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

I just merged these changes into dev.

@berkona @jkaberg
Dev is now up to date with the refactor0.7 branch... and refactor0.7 is now up to date with dev...

I think we should be able to continue working in dev branch now and I believe I have resolved all conflicts to allow a merge into Master when we are ready ;)

from nzbtomedia.

bruvv avatar bruvv commented on May 13, 2024

Right so to make things clear, git pulling the dev branche will still have the QoQ fix in it this time ?

I just did it, now we need to wait for a QoQ release ;)

from nzbtomedia.

clinton-hall avatar clinton-hall commented on May 13, 2024

Yes, that should be the case.
The main issue is new updates in dev may introduce temporary bugs until we get it all tested again.

My apologies for the last merge to master. I did some "complete" tests to ensure it worked, but didn't include the QoQ test in that final round :(

from nzbtomedia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.